Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle interrupted downloads with decompressive transcoding #346

Merged
merged 6 commits into from Sep 21, 2022
Merged

feat: handle interrupted downloads with decompressive transcoding #346

merged 6 commits into from Sep 21, 2022

Conversation

cojenco
Copy link
Contributor

@cojenco cojenco commented Aug 15, 2022 •
edited

Handle interrupted downloads with decompressive transcoding

  • distinguish if transcoding occured by the newly introduced headers x-goog-stored-content-encoding and x-goog-stored-content-length in the JSON API 馃帀
  • check edge case in which the object is served as-is without decompression along with response header content-encoding: gzip
  • reset the stream position for retried range requests if decompressive transcoding occurred (GCS serves back the entire file)

Fixes #303 馃

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/google-resumable-media-python API. labels Aug 15, 2022
@cojenco cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 16, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 16, 2022
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 16, 2022
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 16, 2022
@cojenco cojenco marked this pull request as ready for review August 26, 2022 22:08
@cojenco cojenco requested review from a team as code owners August 26, 2022 22:08
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 29, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 29, 2022
@cojenco cojenco requested a review from frankyn August 29, 2022 17:53
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 6, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 6, 2022
frankyn
frankyn requested changes Sep 15, 2022
View reviewed changes
google/resumable_media/_helpers.py Outdated Show resolved Hide resolved
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 16, 2022
@cojenco cojenco merged commit f4d26b7 into googleapis:main Sep 21, 2022
@release-please release-please bot mentioned this pull request Sep 21, 2022
Merged
@frankyn frankyn mentioned this pull request Jan 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankyn frankyn frankyn approved these changes

Assignees

@frankyn frankyn

Labels
api: storage Issues related to the googleapis/google-resumable-media-python API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle retries in decompressive transcoding downloads
4 participants
@cojenco @frankyn @parthea @yoshi-kokoro