Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add google-auth to aiohttp extra #386

Merged
merged 5 commits into from
Aug 1, 2023
Merged

Conversation

clundin25
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #384

@clundin25 clundin25 requested review from a team as code owners July 18, 2023 09:51
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/google-resumable-media-python API. labels Jul 18, 2023
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 18, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 18, 2023
@parthea parthea changed the title fix: Add google-auth as a dependency to resolve broken tests. fix: Add google-auth as a dependency Jul 18, 2023
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Alternatively, we could add google-auth as an extra, and add conditional logic here to raise an exception to let users know that they need to install the google-auth extra.
https://github.com/googleapis/google-resumable-media-python/blob/main/google/_async_resumable_media/requests/_request_helpers.py#L26

@clundin25
Copy link
Contributor Author

@parthea an extra sounds best to me.

@cojenco
Copy link
Contributor

cojenco commented Jul 18, 2023

+1 to adding an extra instead as the async support is experimental and subject to change.

Additionally, we're also planning to integrate this library into python-storage in the near future. I'm trying to understand how the namespace packaging changes would impact this if any; cc @andrewsg

@andrewsg
Copy link
Contributor

I would prefer extra, or else removing async testing. Async support is currently theoretical and not documented or supported.

@clundin25
Copy link
Contributor Author

Out of curiosity, is there anyone working on stabilizing the Async API?

@clundin25 clundin25 closed this Jul 18, 2023
@clundin25 clundin25 reopened this Jul 18, 2023
@andrewsg
Copy link
Contributor

We don't have it on our roadmap at present as it would require a complete rewrite of python-storage, as well as an additional rewrite of this library in order to avoid having two separate versions of the library that need to be maintained simultaneously. This doesn't mean that async won't happen at all, just that it's not scheduled as of yet.

@clundin25
Copy link
Contributor Author

Okay awesome. Are you a good point of contact for this? I have some questions I want to take offline.

@andrewsg
Copy link
Contributor

Yep, feel free to reach out.

@clundin25
Copy link
Contributor Author

clundin25 commented Jul 18, 2023

I will fix the error tomorrow. Looks like some of the doc tests also use google auth

@clundin25 clundin25 requested a review from parthea July 19, 2023 09:40
@parthea parthea changed the title fix: Add google-auth as a dependency fix: Add google-auth to aiohttp extra Jul 19, 2023
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 19, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 19, 2023
@parthea parthea requested a review from andrewsg July 19, 2023 15:26
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 21, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 21, 2023
@cojenco cojenco added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 1, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 1, 2023
@cojenco cojenco removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 1, 2023
@cojenco cojenco merged commit 30c2ebd into googleapis:main Aug 1, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/google-resumable-media-python API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit tests fail with E ModuleNotFoundError: No module named 'google.auth'
4 participants