Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow sending extra kwargs through to transport.request #7

Closed
dhermes opened this issue May 19, 2017 · 1 comment
Closed

Allow sending extra kwargs through to transport.request #7

dhermes opened this issue May 19, 2017 · 1 comment
Assignees
@plamut
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@dhermes
Copy link
Contributor

dhermes commented May 19, 2017 •
edited

See googleapis/google-cloud-python#3421 (comment) for context.

/cc @sstepashka
@dhermes dhermes self-assigned this May 19, 2017
@JustinBeckwith JustinBeckwith added triage me I really want to be triaged. 🚨 This issue needs some love. labels Dec 8, 2018
@tseaver tseaver added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Jan 16, 2019
@tseaver tseaver mentioned this issue Jan 16, 2019
Closed
@pchauhan-qlogic pchauhan-qlogic mentioned this issue Jul 25, 2019
Closed
@plamut
Copy link
Contributor

plamut commented Jan 8, 2020

I believe this issue can be closed, the http_request helper already accepts extra timeout arguments:

google-resumable-media-python/google/resumable_media/requests/_helpers.py

Lines 101 to 109 in c0732e3

def http_request(
transport,
method,
url,
data=None,
headers=None,
retry_strategy=_DEFAULT_RETRY_STRATEGY,
**transport_kwargs
):

@plamut plamut closed this as completed Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plamut plamut

Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tseaver @dhermes @JustinBeckwith @plamut