This repository has been archived by the owner on Sep 9, 2023. It is now read-only.
feat!: remove WebDataStream, IosAppDataStream, AndroidAppDataStream resources
#377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcf-owl-bot[bot]](https://avatars.githubusercontent.com/in/99011?s=60&v=4){kind=small}
…eam` resources and corresponding operations, as they are replaced by the `DataStream` resource feat: add `restricted_metric_type` field to the `CustomMetric` resource feat!: move the `GlobalSiteTag` resource from the property level to the data stream level PiperOrigin-RevId: 432342398 Source-Link: googleapis/googleapis@a079cb0 Source-Link: googleapis/googleapis-gen@2f29c5a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmYyOWM1YWYzMDU0YTZlMzhkZjIxNThmMDliNzZlYzJmYWZkMGIyZiJ9
trusted-contributions-gcf
bot
added
kokoro:force-run
product-auto-label
bot
added
the
api: analyticsadmin
yoshi-kokoro
removed
the
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
trusted-contributions-gcf
bot
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
meltsufin
approved these changes
Mar 8, 2022
meltsufin
added
the
automerge
meltsufin
approved these changes
Mar 8, 2022
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
gcf-merge-on-green
bot
removed
the
automerge
ikuleshov
approved these changes
Mar 8, 2022
meltsufin
added
the
automerge
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
gcf-merge-on-green
bot
removed
the
automerge
|
Breaking changes. |
|
Breaking changes are expected with this release, since the API is in Alpha. Is it possible to suppress these checks? |
|
Yes. Writing clirr-ignored-difference.xml. |
trusted-contributions-gcf
bot
added
the
kokoro:force-run
trusted-contributions-gcf
bot
added
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
trusted-contributions-gcf
bot
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
suztomo
reviewed
Mar 18, 2022
Comment on lines
54
to
67
| <!-- Not working | ||
| <difference> | ||
| <differenceType>7005</differenceType> | ||
| <className>com/google/analytics/admin/v1alpha/AnalyticsAdminServiceClient</className> | ||
| <method>com.google.analytics.admin.v1alpha.AnalyticsAdminServiceClient$ListMeasurementProtocolSecretsPagedResponse listMeasurementProtocolSecrets(com.google.analytics.admin.v1alpha.WebDataStreamName)</method> | ||
| <to>com.google.analytics.admin.v1alpha.AnalyticsAdminServiceClient$ListMeasurementProtocolSecretsPagedResponse listMeasurementProtocolSecrets(com.google.analytics.admin.v1alpha.DataStreamName)</to> | ||
| </difference>--> | ||
| <!-- This doesn't work either --> | ||
| <difference> | ||
| <differenceType>7005</differenceType> | ||
| <className>com/google/analytics/admin/v1alpha/AnalyticsAdminServiceClient</className> | ||
| <method>* listMeasurementProtocolSecrets(*)</method> | ||
| <to>* listMeasurementProtocolSecrets(*)</to> | ||
| </difference> |
There was a problem hiding this comment.
The CLIRR check is still failing. Why doesn't this entry work?
[INFO] --- clirr-maven-plugin:2.8:check (default-cli) @ google-analytics-admin ---
[INFO] artifact com.google.analytics:google-analytics-admin: checking for updates from central
[INFO] Comparing to version: 0.8.4
Error: 7005: com.google.analytics.admin.v1alpha.AnalyticsAdminServiceClient: Parameter 1 of 'public com.google.analytics.admin.v1alpha.AnalyticsAdminServiceClient$ListMeasurementProtocolSecretsPagedResponse listMeasurementProtocolSecrets(com.google.analytics.admin.v1alpha.WebDataStreamName)' has changed its type to com.google.analytics.admin.v1alpha.DataStreamName
Error: 7005: com.google.analytics.admin.v1alpha.AnalyticsAdminServiceClient: Parameter 1 of 'public com.google.analytics.admin.v1alpha.MeasurementProtocolSecret createMeasurementProtocolSecret(com.google.analytics.admin.v1alpha.WebDataStreamName, com.google.analytics.admin.v1alpha.MeasurementProtocolSecret)' has changed its type to com.google.analytics.admin.v1alpha.DataStreamName
Wrapped:
7005: com.google.analytics.admin.v1alpha.AnalyticsAdminServiceClient: Parameter 1 of 'public com.google.analytics.admin.v1alpha.AnalyticsAdminServiceClient$ListMeasurementProtocolSecretsPagedResponse listMeasurementProtocolSecrets(com.google.analytics.admin.v1alpha.WebDataStreamName)' has changed its type to com.google.analytics.admin.v1alpha.DataStreamName
trusted-contributions-gcf
bot
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
trusted-contributions-gcf
bot
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Neenu1995
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 29, 2022
🤖 I have created a release *beep* *boop* --- ## [0.9.0](v0.8.4...v0.9.0) (2022-03-29) ### ⚠ BREAKING CHANGES * remove `WebDataStream`, `IosAppDataStream`, `AndroidAppDataStream` resources (#377) ### Features * remove `WebDataStream`, `IosAppDataStream`, `AndroidAppDataStream` resources ([#377](#377)) ([b93fa94](b93fa94)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.9.0 ([#385](#385)) ([8644c7f](8644c7f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and corresponding operations, as they are replaced by the
DataStreamresourcefeat: add
restricted_metric_typefield to theCustomMetricresourcefeat!: move the
GlobalSiteTagresource from the property level to the data stream levelPiperOrigin-RevId: 432342398
Source-Link: googleapis/googleapis@a079cb0
Source-Link: https://github.com/googleapis/googleapis-gen/commit/2f29c5af3054a6e38df2158f09b76ec2fafd0b2f
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmYyOWM1YWYzMDU0YTZlMzhkZjIxNThmMDliNzZlYzJmYWZkMGIyZiJ9