Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use row id for addRows in the sample TableInsertRows.java #3000

Closed
baeminbo opened this issue Nov 13, 2023 · 0 comments · Fixed by #2999
Closed

Use row id for addRows in the sample TableInsertRows.java #3000

baeminbo opened this issue Nov 13, 2023 · 0 comments · Fixed by #2999
Assignees
@baeminbo
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. samples Issues that are directly related to samples.

Comments

@baeminbo
Copy link
Contributor

The current sample TableInsertRows.java doesn't explain how to set row ids in InsertAllRequest.addRow. I think it should shows how to set row ids at Streaming Inserts.

  • As TableInsertRowsWithoutRowIds.java explains how-to without row ids, I believe TableInsertRows.java should explain how-to with row ids.
  • Setting no row ids has an unexpected behaviors that retry is disable (b/280865468).
@product-auto-label product-auto-label bot added api: bigquery Issues related to the googleapis/java-bigquery API. samples Issues that are directly related to samples. labels Nov 13, 2023
@baeminbo baeminbo mentioned this issue Nov 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baeminbo baeminbo

Labels
api: bigquery Issues related to the googleapis/java-bigquery API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update TableInsertRows.java baeminbo/java-bigquery
1 participant
@baeminbo