Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use location in BigQueryOption as the default for query #3047

Merged
merged 6 commits into from Dec 19, 2023
Merged

feat: Use location in BigQueryOption as the default for query #3047

merged 6 commits into from Dec 19, 2023

Conversation

PhongChuong
Copy link
Contributor

@PhongChuong PhongChuong commented Dec 15, 2023 •
edited

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #3041 ☕️

@PhongChuong PhongChuong requested a review from a team as a code owner December 15, 2023 15:57
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/java-bigquery API. labels Dec 15, 2023
@PhongChuong PhongChuong requested a review from a team as a code owner December 15, 2023 16:00
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Dec 15, 2023
@obada-ab
Copy link
Member

@PhongChuong I think this change can be tested in ITBigQueryTest by trying to query a dataset that is in a specific location, for example if the location set in BigQueryOptions is US then attempting to query an EU dataset should fail. Something similar is being done here. What do you think?

@PhongChuong
Copy link
Contributor Author

@obada-ab , thanks. Added testStatelessQueriesWithLocation integration test. Please take a look.

@PhongChuong PhongChuong merged commit 270f866 into main Dec 19, 2023
19 checks passed
@PhongChuong PhongChuong deleted the Stateless_location branch December 19, 2023 12:44
@release-please release-please bot mentioned this pull request Dec 19, 2023
Merged
This was referenced Jan 17, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obada-ab obada-ab obada-ab approved these changes

@tswast tswast Awaiting requested review from tswast tswast is a code owner automatically assigned from googleapis/api-bigquery

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Location not set properly in stateless query path
2 participants
@PhongChuong @obada-ab