Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Update universe domain exception error code/message #3113

Merged
merged 2 commits into from Feb 6, 2024

Conversation

PhongChuong
Copy link
Contributor

@PhongChuong PhongChuong commented Feb 2, 2024

This PR updates the universe domain except error code/message to be consistent with the error message used in GAPIC. Specifically, with the error code 401 and the message "The configured universe domain (googleapis.com) does not match the universe domain found in the credentials (foo.com). If you haven't configured the universe domain explicitly, googleapis.com is the default."

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #3112

@PhongChuong PhongChuong requested a review from a team as a code owner February 2, 2024 18:48
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/java-bigquery API. labels Feb 2, 2024
@PhongChuong PhongChuong requested a review from a team as a code owner February 2, 2024 20:16
@tswast tswast removed their request for review February 5, 2024 16:49
@PhongChuong PhongChuong merged commit 5a82c85 into main Feb 6, 2024
19 checks passed
@PhongChuong PhongChuong deleted the universeDomainErrorMessage branch February 6, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update universe domain error message
2 participants