Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Range object to allow reading range value #3236

Merged
merged 9 commits into from Apr 17, 2024
Merged

feat: Add Range object to allow reading range value #3236

merged 9 commits into from Apr 17, 2024

Conversation

PhongChuong
Copy link
Contributor

@PhongChuong PhongChuong commented Apr 10, 2024 •
edited

This PR also adds the ability to use Range query parameter

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #3235 ☕️

@PhongChuong
feat: Add Range object to allow reading range value
567da69 
This PR also adds the ability to use Range query parameter
@PhongChuong PhongChuong requested a review from a team as a code owner April 10, 2024 15:50
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/java-bigquery API. labels Apr 10, 2024
@PhongChuong PhongChuong requested a review from a team as a code owner April 10, 2024 15:52
shollyman
shollyman approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I got caught up misunderstanding the QueryParameterValue mappings until I realized java uses it to provide both value and typing information.

@PhongChuong
Copy link
Contributor Author

Thank you for the review.

@PhongChuong PhongChuong merged commit 2c3399d into main Apr 17, 2024
20 checks passed
@PhongChuong PhongChuong deleted the range branch April 17, 2024 20:02
@release-please release-please bot mentioned this pull request Apr 17, 2024
Merged
This was referenced Apr 30, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

@chalmerlowe chalmerlowe Awaiting requested review from chalmerlowe chalmerlowe is a code owner automatically assigned from googleapis/api-bigquery

@Linchin Linchin Awaiting requested review from Linchin

@alvarowolfx alvarowolfx Awaiting requested review from alvarowolfx

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support reading range value
2 participants
@PhongChuong @shollyman