fix: Add a throwException behavior when the StreamWriter inflight queue is full #1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
GaoleMeng
approved these changes
May 6, 2022
yirutang
changed the title
yirutang
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
yirutang
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
tkosse
reviewed
May 6, 2022
| Status.fromCode(Code.RESOURCE_EXHAUSTED) | ||
| .withDescription( | ||
| "Exceeds client side inflight buffer, consider add more buffer or open more connections.")); | ||
| } else if (this.limitExceededBehavior == FlowController.LimitExceededBehavior.Ignore) { |
There was a problem hiding this comment.
Wouldn't be the ignore option just a break; at this point?
There was a problem hiding this comment.
L735, by default it is Block.
There was a problem hiding this comment.
What I meant was, that the actual meaning of LimitExceededBehavior.Ignore is, that this inflight quota counting is simply ignored. So the StreamWriter just continues sending. But this option is probably not that relevant for productive setups.
Suggested change
| } else if (this.limitExceededBehavior == FlowController.LimitExceededBehavior.Ignore) { | |
| } else if (this.limitExceededBehavior == FlowController.LimitExceededBehavior.Ignore) { | |
| break; | |
| } |
There was a problem hiding this comment.
I tend to think we shouldn't allow it...
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
May 24, 2022
🤖 I have created a release *beep* *boop* --- ## [2.14.0](v2.13.0...v2.14.0) (2022-05-19) ### Features * add build scripts for native image testing in Java 17 ([#1440](#1440)) ([#1655](#1655)) ([ac2dfaf](ac2dfaf)) ### Bug Fixes * Add a throwException behavior when the StreamWriter inflight queue is full ([#1642](#1642)) ([4dcf0d5](4dcf0d5)) * add extra JsonWriterTest to show that the LimitBehavior addition is not breaking ([#1643](#1643)) ([320f5fc](320f5fc)) * ints/longs are numerics ([#1596](#1596)) ([d046c8d](d046c8d)), closes [#1516](#1516) ### Dependencies * update arrow.version to v8 ([#1645](#1645)) ([06e3c34](06e3c34)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.12.0 ([#1654](#1654)) ([ec4f60b](ec4f60b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a throwException behavior when the StreamWriter inflight queue is full.
Fixes #1539 ☕️
If you write sample code, please follow the samples format.