feat: provide sample code for row-level error handling #1863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: This pull request is touching the following templated files:
|
product-auto-label
bot
added
api: bigquerystorage
agrawal-siddharth
force-pushed
the
rowErrorSampleCode
branch
from
18e97b8
to
4118376
Compare
yirutang
reviewed
Oct 31, 2022
| // Retry the remaining valid rows. | ||
| if (dataNew.length() > 0) { | ||
| try { | ||
| this.parent.append(new AppendContext(dataNew, 0)); |
There was a problem hiding this comment.
Is there a way to start another thread and do this append? Currently this append can block waiting for inflight limit...
There was a problem hiding this comment.
Done. Both retries and row-errors are now handled by calls to append() made from a separate thread.
yirutang
reviewed
Oct 31, 2022
samples/snippets/src/test/java/com/example/bigquerystorage/WriteToDefaultStreamIT.java
Outdated
Show resolved
Hide resolved
agrawal-siddharth
force-pushed
the
rowErrorSampleCode
branch
from
4118376
to
43798cb
Compare
agrawal-siddharth
force-pushed
the
rowErrorSampleCode
branch
from
43798cb
to
27d4b2a
Compare
yirutang
approved these changes
Nov 11, 2022
yirutang
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.