fix: we should isolate the client used in StreamWriter and the client used in ConnectionWorker #1933
+113
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
product-auto-label
bot
added
size: m
GaoleMeng
approved these changes
Jan 17, 2023
GaoleMeng
reviewed
Jan 17, 2023
| @@ -206,7 +205,9 @@ private StreamWriter(Builder builder) throws IOException { | |||
| "Trying to enable connection pool in non-default stream."); | |||
| } | |||
|
|
|||
| BigQueryWriteClient client = getBigQueryWriteClient(builder); | |||
| // We need a client to perform some getWriteStream calls. | |||
| BigQueryWriteClient client = | |||
There was a problem hiding this comment.
why do we need to create another client here if the passed in client is null?
we won't use the newly created client?
GaoleMeng
reviewed
Jan 17, 2023
...e-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/StreamWriter.java
Outdated
Show resolved
Hide resolved
yirutang
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
yirutang
added
kokoro:run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:run
yirutang
added
the
kokoro:run
yoshi-kokoro
removed
the
kokoro:run
yirutang
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
yirutang
added
kokoro:run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
kokoro:run
yirutang
added
the
kokoro:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turned out dataflow is using a connection while they might close the externally passed in client. Resulting in a non-recoverable UNAVAILABLE error.