Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding deprecated message to v1beta2 manual client #2098

Merged
merged 5 commits into from Jan 2, 2024
Merged

feat: Adding deprecated message to v1beta2 manual client #2098

merged 5 commits into from Jan 2, 2024

Conversation

yirutang
Copy link
Contributor

@yirutang yirutang commented May 1, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@yirutang yirutang requested a review from a team as a code owner May 1, 2023 22:57
@yirutang yirutang requested a review from shollyman May 1, 2023 22:57
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels May 1, 2023
@yirutang yirutang requested a review from Neenu1995 May 1, 2023 22:57
@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label May 2, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 2, 2023
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner May 2, 2023 00:04
@Neenu1995 Neenu1995 requested a review from suztomo May 3, 2023 19:16
@Neenu1995
Copy link
Contributor

@suztomo PTAL

@yirutang
Copy link
Contributor Author

@suztomo PTAL

Hi Neenu, the Turbo has been approved and we sent out an MSA. We should be able to add the deprecate annotation now.
https://buganizer.corp.google.com/issues/288590036

@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 9, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 9, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 9, 2023
@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 14, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 14, 2023
@yirutang yirutang merged commit f150780 into googleapis:main Jan 2, 2024
17 checks passed
@release-please release-please bot mentioned this pull request Dec 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suztomo suztomo suztomo approved these changes

@Neenu1995 Neenu1995 Neenu1995 approved these changes

@shollyman shollyman Awaiting requested review from shollyman shollyman is a code owner automatically assigned from googleapis/api-bigquery

Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yirutang @Neenu1995 @suztomo @yoshi-kokoro