Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding setting KeepAlive to JsonWriter sample #2104

Merged
merged 4 commits into from May 3, 2023
Merged

feat: Adding setting KeepAlive to JsonWriter sample #2104

merged 4 commits into from May 3, 2023

Conversation

yirutang
Copy link
Contributor

@yirutang yirutang commented May 3, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label May 3, 2023
@yirutang yirutang requested a review from GaoleMeng May 3, 2023 20:00
@product-auto-label product-auto-label bot added api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. samples Issues that are directly related to samples. labels May 3, 2023
@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label May 3, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 3, 2023
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners May 3, 2023 21:16
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels May 3, 2023
@yirutang yirutang merged commit a5b95c1 into googleapis:main May 3, 2023
18 checks passed
@release-please release-please bot mentioned this pull request May 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaoleMeng GaoleMeng GaoleMeng approved these changes

Assignees

@Shabirmean Shabirmean

Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. samples Issues that are directly related to samples. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yirutang @GaoleMeng @Shabirmean