Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keepalive in grpc channel for Bigtable client. #2681

Closed
sushanb opened this issue Nov 6, 2020 · 0 comments · Fixed by #2682
Closed

Add keepalive in grpc channel for Bigtable client. #2681

sushanb opened this issue Nov 6, 2020 · 0 comments · Fixed by #2682
Assignees
@igorbernstein2
Labels
api: bigtable Issues related to the googleapis/java-bigtable-hbase API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@sushanb
Copy link
Contributor

sushanb commented Nov 6, 2020

Keepalive is recommended to use when your peer dies before it is able to notify you or does not notify you. The reasons can be kernel panic, termination of the process handling that pee

Hence, if a server does not send GOAWAY to the client, the grpc client will send packets to the TCP peer but the TCP peer will not send any packets. This can happen when a server nodes goes down due to machine failure, release/rollouts.

Adding keepalive will prevent requests being blackholed/client being hung.
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable-hbase API. label Nov 6, 2020
@sushanb sushanb mentioned this issue Nov 6, 2020
Merged
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Nov 6, 2020
@kolea2 kolea2 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Nov 6, 2020
@sushanb sushanb mentioned this issue Nov 6, 2020
Merged
@HemangChothani HemangChothani mentioned this issue Dec 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@igorbernstein2 igorbernstein2

Labels
api: bigtable Issues related to the googleapis/java-bigtable-hbase API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add keepalive in grpc channelbuilder
4 participants
@sushanb @igorbernstein2 @yoshi-automation @kolea2