feat: change stream retention to create and update table #1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
Change-Id: I6eec06f3e3178143150490aa5fd97b83b1878cd2
tonytanger
force-pushed
the
cdc_update_table
branch
from
8a35fd6
to
b9db2eb
Compare
added 3 commits
June 29, 2023 12:56
…lete change stream enabled table Change-Id: Ia2f92ccae3a2582da771b68a26adc1ab5f9d516e
Change-Id: I485507dd224eb0a3a160f7e9b5c569e1ae13ed84
Change-Id: I9b64e208ba3bf47f39a7bac3e4a3eb851b2c9468
tonytanger
force-pushed
the
cdc_update_table
branch
from
50f3431
to
7a7e40d
Compare
tonytanger
changed the title
Change-Id: I8076da5631aa4dc4f97bba88c8f799303e81a65f
mutianf
reviewed
Jul 5, 2023
| @@ -76,6 +78,22 @@ public CreateTableRequest addSplit(ByteString key) { | |||
| return this; | |||
| } | |||
|
|
|||
| /** Add change stream retention period between 1 day and 7 days */ | |||
| public CreateTableRequest addChangeStreamRetention(Duration retention) { | |||
| Preconditions.checkNotNull(retention); | |||
There was a problem hiding this comment.
should we add precondition to check retention is between 1 and 7?
There was a problem hiding this comment.
I wasn't sure what the philosophy is. Checking here would allow us to fail faster but if we widen the retention period then we have to change on the client side as well.
There was a problem hiding this comment.
Per https://google.aip.dev/client-libraries/4223, I think we should rely on the server side validation.
mutianf
approved these changes
Jul 5, 2023
gcf-owl-bot
bot
removed
the
owlbot:run
mutianf
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
🤖 I have created a release *beep* *boop* --- ## [2.25.0](https://togithub.com/googleapis/java-bigtable/compare/v2.24.1...v2.25.0) (2023-07-14) ### Features * Change stream retention to create and update table ([#1823](https://togithub.com/googleapis/java-bigtable/issues/1823)) ([05fca58](https://togithub.com/googleapis/java-bigtable/commit/05fca581d4225769cc581e26e679e6bca105055b)) ### Bug Fixes * Fix batch mutation limit ([#1808](https://togithub.com/googleapis/java-bigtable/issues/1808)) ([ed24d4f](https://togithub.com/googleapis/java-bigtable/commit/ed24d4fdc67c6d0af66ea055ba1ad7f7c037a361)) * Update default sample row key attempt timeout to 5 min ([#1827](https://togithub.com/googleapis/java-bigtable/issues/1827)) ([2f363ef](https://togithub.com/googleapis/java-bigtable/commit/2f363ef3636c2810c322bb5978cc586f8aec2ef2)) ### Documentation * Fix formatting for reversed order field example ([#1836](https://togithub.com/googleapis/java-bigtable/issues/1836)) ([10a0426](https://togithub.com/googleapis/java-bigtable/commit/10a0426f580b86b26541b95a778bb8b7f6562383)) * Increase the maximum retention period for a Cloud Bigtable backup from 30 days to 90 days ([#1826](https://togithub.com/googleapis/java-bigtable/issues/1826)) ([159fe38](https://togithub.com/googleapis/java-bigtable/commit/159fe3857735c9061672fc951388215edb0a324c)) ### Dependencies * Update dependency com.google.cloud:google-cloud-monitoring-bom to v3.22.0 ([#1838](https://togithub.com/googleapis/java-bigtable/issues/1838)) ([fba2c49](https://togithub.com/googleapis/java-bigtable/commit/fba2c49e9e71209289497f53868aa561c0fba7a3)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.13.0 ([#1833](https://togithub.com/googleapis/java-bigtable/issues/1833)) ([cb160af](https://togithub.com/googleapis/java-bigtable/commit/cb160af8e66ec6693ed0d3286c654a93094b68a3)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1821 adding update table support.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.