Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update dependency com.google.cloud:google-cloud-shared-dependencies to v3.13.0 #1833

Merged
merged 1 commit into from Jul 10, 2023

Conversation

mutianf
Copy link
Contributor

@mutianf mutianf commented Jul 7, 2023

BEGIN_COMMIT_OVERRIDE
deps: update dependency com.google.cloud:google-cloud-shared-dependencies to v3.13.0 (#1833)
END_COMMIT_OVERRIDE

Update dependency to v3.13.0 and fix the tests since we changed the logic in BatcherImpl: googleapis/sdk-platform-java#1790.

The shouldFlush logic changed from element >= maxElement to element > maxElement. This means if flow controller has the same element count threshold as the batch element threshold, the resource is going to get locked up. Fixing the condition when we build BatchCallSettings and the tests.

@mutianf mutianf requested review from a team as code owners July 7, 2023 20:53
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/java-bigtable API. labels Jul 7, 2023
@mutianf mutianf added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 10, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 10, 2023
@mutianf mutianf merged commit cb160af into googleapis:main Jul 10, 2023
20 checks passed
@mutianf mutianf deleted the fix-test branch July 10, 2023 17:42
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 17, 2023
🤖 I have created a release *beep* *boop*
---


## [2.25.0](https://togithub.com/googleapis/java-bigtable/compare/v2.24.1...v2.25.0) (2023-07-14)


### Features

* Change stream retention to create and update table ([#1823](https://togithub.com/googleapis/java-bigtable/issues/1823)) ([05fca58](https://togithub.com/googleapis/java-bigtable/commit/05fca581d4225769cc581e26e679e6bca105055b))


### Bug Fixes

* Fix batch mutation limit ([#1808](https://togithub.com/googleapis/java-bigtable/issues/1808)) ([ed24d4f](https://togithub.com/googleapis/java-bigtable/commit/ed24d4fdc67c6d0af66ea055ba1ad7f7c037a361))
* Update default sample row key attempt timeout to 5 min ([#1827](https://togithub.com/googleapis/java-bigtable/issues/1827)) ([2f363ef](https://togithub.com/googleapis/java-bigtable/commit/2f363ef3636c2810c322bb5978cc586f8aec2ef2))


### Documentation

* Fix formatting for reversed order field example ([#1836](https://togithub.com/googleapis/java-bigtable/issues/1836)) ([10a0426](https://togithub.com/googleapis/java-bigtable/commit/10a0426f580b86b26541b95a778bb8b7f6562383))
* Increase the maximum retention period for a Cloud Bigtable backup from 30 days to 90 days ([#1826](https://togithub.com/googleapis/java-bigtable/issues/1826)) ([159fe38](https://togithub.com/googleapis/java-bigtable/commit/159fe3857735c9061672fc951388215edb0a324c))


### Dependencies

* Update dependency com.google.cloud:google-cloud-monitoring-bom to v3.22.0 ([#1838](https://togithub.com/googleapis/java-bigtable/issues/1838)) ([fba2c49](https://togithub.com/googleapis/java-bigtable/commit/fba2c49e9e71209289497f53868aa561c0fba7a3))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.13.0 ([#1833](https://togithub.com/googleapis/java-bigtable/issues/1833)) ([cb160af](https://togithub.com/googleapis/java-bigtable/commit/cb160af8e66ec6693ed0d3286c654a93094b68a3))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
@blakeli0
Copy link
Contributor

@mutianf FlowControlSettings is still a public setting that customers can override, it's unlikely but I think it's possible for customers to run into the same deadlock issue as we run into in unit tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants