fix: check that all bulk mutation entries are accounted for (#1907) #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is#1907) Add a fail safe that marks missing entries in a response as permanent errors. Previously the client assumed that all entries were present and only looked for errors Change-Id: Ie3f294fd6bb19ec17662b58bfe9c75a3eed81097 Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/java-bigtable/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> ☕️ If you write sample code, please follow the [samples format]( https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md).
product-auto-label
bot
added
size: m
igorbernstein2
approved these changes
Sep 15, 2023
gcf-owl-bot
bot
removed
the
owlbot:run
kolea2
added
automerge
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 18, 2023
🤖 I have created a release *beep* *boop* --- ## [2.25.2](https://togithub.com/googleapis/java-bigtable/compare/v2.25.0...v2.25.2) (2023-09-18) ### Bug Fixes * Check that all bulk mutation entries are accounted for ([#1907](https://togithub.com/googleapis/java-bigtable/issues/1907)) ([#1923](https://togithub.com/googleapis/java-bigtable/issues/1923)) ([e4db745](https://togithub.com/googleapis/java-bigtable/commit/e4db74534690eb090347c00047eecbd45f5a22b7)) * Make sure to propagate the response when throttling is enabled ([#1908](https://togithub.com/googleapis/java-bigtable/issues/1908)) ([#1922](https://togithub.com/googleapis/java-bigtable/issues/1922)) ([7ec5dd5](https://togithub.com/googleapis/java-bigtable/commit/7ec5dd5bc9499b01f5e330c28c9c5ee8cfadad68)) ### Miscellaneous Chores * Update release tag to 2.25.2 ([#1926](https://togithub.com/googleapis/java-bigtable/issues/1926)) ([9d5868b](https://togithub.com/googleapis/java-bigtable/commit/9d5868b2350f2b24b5988ebe3adb2e77e36c8a5a)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
port of #1907