Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the export logic for per-connection error rate metric #2121

Merged

Conversation

rkaregar
Copy link
Member

@rkaregar rkaregar commented Feb 16, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed

Fixes #2110 ☕️

Internal document about the feature: https://docs.google.com/document/d/1XPKdjV1sM80pc1ptaUW9B_WDXfdO-v69jCCRPI6aLPI

If you write sample code, please follow the samples format.

@rkaregar rkaregar requested review from a team as code owners February 16, 2024 21:23
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Feb 16, 2024
Copy link

conventional-commit-lint-gcf bot commented Feb 16, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label Feb 16, 2024
Copy link
Contributor

@mutianf mutianf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt after nit

@mutianf mutianf added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 20, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 20, 2024
@mutianf mutianf added the automerge Merge the pull request once unit tests and other checks pass. label Feb 20, 2024
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 21, 2024
@mutianf mutianf merged commit d053f2d into googleapis:main Feb 21, 2024
21 checks passed
gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 21, 2024
🤖 I have created a release *beep* *boop*
---


## [2.34.0](https://togithub.com/googleapis/java-bigtable/compare/v2.33.0...v2.34.0) (2024-02-21)


### Features

* Add the export logic for per-connection error rate metric ([#2121](https://togithub.com/googleapis/java-bigtable/issues/2121)) ([d053f2d](https://togithub.com/googleapis/java-bigtable/commit/d053f2dc98eb8576f33471d728c6fbf32d537ece))
* Create the backbone of counting errors per connection each minute. ([#2094](https://togithub.com/googleapis/java-bigtable/issues/2094)) ([7d27816](https://togithub.com/googleapis/java-bigtable/commit/7d27816b959a06412f59f49023611f0bca8e3536))


### Dependencies

* Update actions/setup-java action to v4 ([#2106](https://togithub.com/googleapis/java-bigtable/issues/2106)) ([a694296](https://togithub.com/googleapis/java-bigtable/commit/a694296a76faefe31585aabc9dce0adcf4a342bf))
* Update dependency com.google.cloud:gapic-libraries-bom to v1.30.0 ([#2126](https://togithub.com/googleapis/java-bigtable/issues/2126)) ([f613bd0](https://togithub.com/googleapis/java-bigtable/commit/f613bd0dd449d218a0d8b6d20344155f9762cfb1))
* Update dependency com.google.cloud:sdk-platform-java-config to v3.25.0 ([#2113](https://togithub.com/googleapis/java-bigtable/issues/2113)) ([ba1973e](https://togithub.com/googleapis/java-bigtable/commit/ba1973e20c4cbb9be778840cc202eb7e4daf04f4))
* Update dependency com.google.truth.extensions:truth-proto-extension to v1.4.1 ([#2119](https://togithub.com/googleapis/java-bigtable/issues/2119)) ([0a7ad66](https://togithub.com/googleapis/java-bigtable/commit/0a7ad66fa9e2c1858f51c25d1ea01b26da0b944f))
* Update dependency org.graalvm.buildtools:junit-platform-native to v0.10.1 ([#2122](https://togithub.com/googleapis/java-bigtable/issues/2122)) ([99ec284](https://togithub.com/googleapis/java-bigtable/commit/99ec28425c2caac6a992cb7edd83f2029cce92ec))
* Update dependency org.graalvm.buildtools:native-maven-plugin to v0.10.1 ([#2123](https://togithub.com/googleapis/java-bigtable/issues/2123)) ([12d961a](https://togithub.com/googleapis/java-bigtable/commit/12d961aad5d15feb27a7996de8b9a626fcdfbc5b))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export per-connection error rate metrics
2 participants