Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

fix: suppress checkstyle for certain methods #921

Merged
merged 3 commits into from
Jul 13, 2022
Merged

Conversation

alicejli
Copy link
Contributor

Some PRs are failing checkstyle tests:

Error:  src/main/java/dlp/snippets/RiskAnalysisKMap.java:[18,1] (whitespace) EmptyLineSeparator: '//' should be separated from previous line.
Error:  src/main/java/dlp/snippets/RiskAnalysisKMap.java:[53,7] (naming) AbbreviationAsWordInName: Abbreviation in name 'RiskAnalysisKMap' must contain no more than '1' consecutive capital letters.
Error:  src/main/java/dlp/snippets/RiskAnalysisKMap.java:[65,22] (naming) AbbreviationAsWordInName: Abbreviation in name 'calculateKMap' must contain no more than '1' consecutive capital letters.
Error:  src/main/java/dlp/snippets/RiskAnalysisLDiversity.java:[55,7] (naming) AbbreviationAsWordInName: Abbreviation in name 'RiskAnalysisLDiversity' must contain no more than '1' consecutive capital letters.
Error:  src/main/java/dlp/snippets/RiskAnalysisLDiversity.java:[67,22] (naming) AbbreviationAsWordInName: Abbreviation in name 'calculateLDiversity' must contain no more than '1' consecutive capital letters.
Error:  src/main/java/dlp/snippets/RiskAnalysisKAnonymity.java:[52,7] (naming) AbbreviationAsWordInName: Abbreviation in name 'RiskAnalysisKAnonymity' must contain no more than '1' consecutive capital letters.
Error:  src/main/java/dlp/snippets/RiskAnalysisKAnonymity.java:[64,22] (naming) AbbreviationAsWordInName: Abbreviation in name 'calculateKAnonymity' must contain no more than '1' consecutive capital letters.
``

This updates the empty line error, and suppresses the Checkstyle check for methods that are correctly formatted in camelCase. 

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: dlp Issues related to the googleapis/java-dlp API. labels Jul 12, 2022
@alicejli alicejli marked this pull request as ready for review July 12, 2022 19:21
@alicejli alicejli added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 12, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 12, 2022
@alicejli alicejli requested a review from a team as a code owner July 12, 2022 20:13
@alicejli alicejli merged commit 28ae04d into main Jul 13, 2022
@alicejli alicejli deleted the suppressCheckStyle branch July 13, 2022 13:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: dlp Issues related to the googleapis/java-dlp API. size: xs Pull request size is extra small.
Projects
None yet
2 participants