Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove 'x-goog-request-params' header from GRPC requests due to incorrect format. #1358

Merged
merged 4 commits into from Jul 19, 2023
Merged

fix: Remove 'x-goog-request-params' header from GRPC requests due to incorrect format. #1358

merged 4 commits into from Jul 19, 2023

Conversation

tom-andersen
Copy link
Contributor

@tom-andersen tom-andersen commented Jul 18, 2023 •
edited

Remove 'x-goog-request-params' from headers, and fallback on google-cloud-resource-prefix instead.

@tom-andersen tom-andersen added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 18, 2023
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jul 18, 2023
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • google-cloud-firestore/src/main/java/com/google/cloud/firestore/v1/stub/GrpcFirestoreStub.java

@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/java-firestore API. label Jul 18, 2023
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jul 19, 2023
@tom-andersen tom-andersen changed the title Work around fix: Avoid encoding problem by omitting 'x-goog-request-params' header. Jul 19, 2023
@tom-andersen tom-andersen marked this pull request as ready for review July 19, 2023 19:49
@tom-andersen tom-andersen requested a review from a team as a code owner July 19, 2023 19:49
@tom-andersen tom-andersen removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 19, 2023
@tom-andersen tom-andersen requested a review from wu-hui July 19, 2023 19:51
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner July 19, 2023 19:57
@tom-andersen tom-andersen changed the title fix: Avoid encoding problem by omitting 'x-goog-request-params' header. fix: Remove 'x-goog-request-params' header from GRPC requests due to incorrect format. Jul 19, 2023
@tom-andersen tom-andersen merged commit 1a1bf5f into main Jul 19, 2023
18 of 19 checks passed
@tom-andersen tom-andersen deleted the tomandersen/workaround branch July 19, 2023 21:39
@release-please release-please bot mentioned this pull request Jul 19, 2023
Merged
cherylEnkidu pushed a commit that referenced this pull request Dec 11, 2023
@tom-andersen @gcf-owl-bot @cherylEnkidu
fix: Remove 'x-goog-request-params' header from GRPC requests due to …
2d6ba69 
…incorrect format. (#1358)

* Work around

* Remove `x-goog-request-params`

* Lint

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsannas ehsannas ehsannas approved these changes

@MarkDuckworth MarkDuckworth Awaiting requested review from MarkDuckworth

@wu-hui wu-hui Awaiting requested review from wu-hui

Assignees

@ehsannas ehsannas

@wu-hui wu-hui

Labels
api: firestore Issues related to the googleapis/java-firestore API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tom-andersen @ehsannas @wu-hui