fix: internalStream
should handle duplicate onComplete
s.
#1523
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The burden of handling duplicate
onComplete
signals should be oninternalStream
, and not on all the callers that use it.currently
get()
andstream()
APIs call the underlyinginternalStream
, and each of them are implementing the same logic to avoid duplicate completions. This should be handled at the lower (internalStream) function. Also, future callers ofinternalStream
may not realize they need to implement this logic.