Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Thread safe UpdateBuilder #1537

Merged
merged 23 commits into from
Jan 24, 2024
Merged

fix: Thread safe UpdateBuilder #1537

merged 23 commits into from
Jan 24, 2024

Conversation

tom-andersen
Copy link
Contributor

@tom-andersen tom-andersen commented Jan 19, 2024 •
edited
Loading

b/318413194

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: firestore Issues related to the googleapis/java-firestore API. labels Jan 19, 2024
@tom-andersen tom-andersen force-pushed the tomandersen/threadSafeUpdateBuilder branch from 266ce6f to 138ebb8 Compare January 19, 2024 18:26
@tom-andersen tom-andersen changed the title Thread safe UpdateBuilder fix: Thread safe UpdateBuilder Jan 19, 2024
@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link

conventional-commit-lint-gcf bot commented Jan 19, 2024 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@tom-andersen tom-andersen marked this pull request as ready for review January 19, 2024 19:53
@tom-andersen tom-andersen requested a review from a team as a code owner January 19, 2024 19:53
@tom-andersen tom-andersen force-pushed the tomandersen/threadSafeUpdateBuilder branch from b622df8 to facf7cf Compare January 19, 2024 20:25
@tom-andersen tom-andersen added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 19, 2024
@tom-andersen tom-andersen requested a review from a team as a code owner January 22, 2024 16:36
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels Jan 22, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 22, 2024
tom-andersen and others added 4 commits January 23, 2024 14:15
@tom-andersen
Refactor
b2ff585
@gcf-owl-bot @dconeybe
fix(deps): Update the Java code generator (gapic-generator-java) to 2…
5cb6c52 
….32.0 (#1534)

* chore: Add FindNearest API to the preview branch
docs: Improve the documentation on Document.fields

PiperOrigin-RevId: 599602467

Source-Link: googleapis/googleapis@d32bd97

Source-Link: googleapis/googleapis-gen@0545ffc
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDU0NWZmYzQ4OGI4MmQzYTQ3NzExMThjOTIzZDY0Y2QwYjc1OTk1MyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix(deps): Update the Java code generator (gapic-generator-java) to 2.32.0

PiperOrigin-RevId: 599914188

Source-Link: googleapis/googleapis@17e6661

Source-Link: googleapis/googleapis-gen@d86ba5b
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDg2YmE1YmU1MzdlNDg5NDM1MTA1Y2E4NTU2NmNjNDEwMzMwMWFiYSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@renovate-bot @dconeybe
test(deps): update dependency com.google.truth:truth to v1.3.0 (#1538)
bcc366d
@dconeybe
make some methods static: applyFieldMask() and convertToFieldPaths()
396c15f
@generated-files-bot Generated Files Bot
Copy link

Warning: This pull request is touching the following templated files:

  • google-cloud-firestore-admin/src/main/java/com/google/cloud/firestore/v1/FirestoreAdminClient.java
  • google-cloud-firestore-admin/src/main/java/com/google/cloud/firestore/v1/stub/FirestoreAdminStubSettings.java
  • google-cloud-firestore/src/main/java/com/google/cloud/firestore/v1/FirestoreClient.java
  • google-cloud-firestore/src/main/java/com/google/cloud/firestore/v1/stub/FirestoreStubSettings.java
  • proto-google-cloud-firestore-v1/src/main/java/com/google/firestore/v1/Document.java
  • proto-google-cloud-firestore-v1/src/main/java/com/google/firestore/v1/DocumentOrBuilder.java
  • proto-google-cloud-firestore-v1/src/main/java/com/google/firestore/v1/StructuredQuery.java
  • proto-google-cloud-firestore-v1/src/main/proto/google/firestore/v1/document.proto
  • proto-google-cloud-firestore-v1/src/main/proto/google/firestore/v1/query.proto
  • samples/install-without-bom/pom.xml
  • samples/snapshot/pom.xml
  • samples/snippets/pom.xml

@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Jan 23, 2024
@dconeybe dconeybe changed the base branch from main to java7 January 23, 2024 20:30
@dconeybe dconeybe changed the base branch from java7 to main January 23, 2024 20:30
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Jan 23, 2024
dconeybe
dconeybe requested changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this improvement! I've just left a few minor nits, but overall LGTM.

google-cloud-firestore/src/main/java/com/google/cloud/firestore/BulkCommitBatch.java Show resolved Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/BulkCommitBatch.java Outdated Show resolved Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/UpdateBuilder.java Outdated Show resolved Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/UpdateBuilder.java Outdated Show resolved Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/UpdateBuilder.java Outdated Show resolved Hide resolved
@dconeybe dconeybe assigned tom-andersen and unassigned dconeybe Jan 23, 2024
@dconeybe dconeybe removed their assignment Jan 24, 2024
@tom-andersen tom-andersen merged commit f9cdab5 into main Jan 24, 2024
24 checks passed
@tom-andersen tom-andersen deleted the tomandersen/threadSafeUpdateBuilder branch January 24, 2024 17:27
@release-please release-please bot mentioned this pull request Jan 24, 2024
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Jan 25, 2024
@release-please
chore(main): release 3.16.1 (#1528)
de842a0 
🤖 I have created a release *beep* *boop*
---


## [3.16.1](https://togithub.com/googleapis/java-firestore/compare/v3.16.0...v3.16.1) (2024-01-25)


### Bug Fixes

* `internalStream` should handle duplicate `onComplete`s. ([#1523](https://togithub.com/googleapis/java-firestore/issues/1523)) ([b3067d7](https://togithub.com/googleapis/java-firestore/commit/b3067d7b382ea5c4c9124a12a701abe2f7289503))
* Allow an explicit MustExist precondition for update ([#1542](https://togithub.com/googleapis/java-firestore/issues/1542)) ([46e09aa](https://togithub.com/googleapis/java-firestore/commit/46e09aad7f6689d4dfe82bd284905d52edda4364))
* **deps:** Update the Java code generator (gapic-generator-java) to 2.32.0 ([#1534](https://togithub.com/googleapis/java-firestore/issues/1534)) ([2281320](https://togithub.com/googleapis/java-firestore/commit/2281320fd924a1d6c259a493ce703a51f0cd8a03))
* Make rollback best effort. ([#1515](https://togithub.com/googleapis/java-firestore/issues/1515)) ([4c39af5](https://togithub.com/googleapis/java-firestore/commit/4c39af50d6d416440164fc5d5360f3912cd8f01b))
* Thread safe UpdateBuilder ([#1537](https://togithub.com/googleapis/java-firestore/issues/1537)) ([f9cdab5](https://togithub.com/googleapis/java-firestore/commit/f9cdab5885bd1d500c6fc412eb3090cea9347d0e))


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.22.0 ([#1535](https://togithub.com/googleapis/java-firestore/issues/1535)) ([04c0e07](https://togithub.com/googleapis/java-firestore/commit/04c0e0736ddcd49eb42aacb31e2fc087b2a39754))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.23.0 ([#1544](https://togithub.com/googleapis/java-firestore/issues/1544)) ([79713bf](https://togithub.com/googleapis/java-firestore/commit/79713bf0fa376a4d22518ae2f5da9660795d9f89))


### Documentation

* Fix formatting due to unclosed backtick ([#1529](https://togithub.com/googleapis/java-firestore/issues/1529)) ([3c78fe3](https://togithub.com/googleapis/java-firestore/commit/3c78fe3c248cb212c6e4f91a5bb7aeb8b9b003b0))
* Rring BulkWriter out of BetaApi status. ([#1513](https://togithub.com/googleapis/java-firestore/issues/1513)) ([c2812f7](https://togithub.com/googleapis/java-firestore/commit/c2812f7cb72257512ffecc98ec1bdb1109d7d044))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
@release-please release-please bot mentioned this pull request May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dconeybe dconeybe dconeybe approved these changes

Assignees

@tom-andersen tom-andersen

Labels
api: firestore Issues related to the googleapis/java-firestore API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tom-andersen @dconeybe @yoshi-kokoro @JoeWang1127 @renovate-bot