Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, firestore cloud.google.com DocFX generation fails:
The current DocFX profile excludes that file for this reason: https://github.com/googleapis/java-firestore/blob/main/pom.xml#L263.
However, there was a recent change made to the shared DocFX profile (googleapis/java-shared-config#744) that removed some of these properties due to an unrelated issue caused by the maven-javadoc-plugin upgrade to 3.6.3 that no longer allows null parameters to be passed in. That change caused this property to no longer be respected with DocFX generation.
This PR updates the Firestore profile such that the file exclusion property should be respected during javadoc generation (to be confirmed in googleapis/java-shared-config#771).