-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Query Profiling #1609
feat: Query Profiling #1609
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few points where the observer pattern implementation breaks down in my opinion. Otherwise, looks good!
google-cloud-firestore/src/main/java/com/google/cloud/firestore/AggregateQuery.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/ExplainMetrics.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/PlanSummary.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/Query.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/AggregateQuery.java
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/AggregateQuery.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/AggregateQuery.java
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/AggregateQuery.java
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/AggregateQuery.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/PlanSummary.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/Query.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/ExplainMetrics.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/ExplainMetrics.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/AggregateQuery.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will need some more time, but here is a preliminary review.
google-cloud-firestore/src/main/java/com/google/cloud/firestore/AggregateQuery.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/AggregateQuery.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/AggregateQuery.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Consider anything remaining as nits
.
Beyond this PR, this library needs better logging. I would like to see that every usage of SettableApiFuture
also include conditional logging if set
or setException
returns false. These represent unexpected situations that we are simply ignoring right now.
No description provided.