Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Temporary error_prone_annotations exclusion rules from poms #96

Closed
athakor opened this issue Feb 6, 2020 · 0 comments · Fixed by #97
Closed

Remove Temporary error_prone_annotations exclusion rules from poms #96

athakor opened this issue Feb 6, 2020 · 0 comments · Fixed by #97
Assignees
@athakor
Labels
api: firestore Issues related to the googleapis/java-firestore API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@athakor
Copy link
Contributor

athakor commented Feb 6, 2020 •
edited

As of grpc-api:1.26.0 there is a failure for error_prone_annotations
The exclusion should be removed from the poms when there is no longer a disparity.
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/java-firestore API. label Feb 6, 2020
@athakor athakor self-assigned this Feb 6, 2020
@athakor athakor added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Feb 6, 2020
@athakor athakor mentioned this issue Feb 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@athakor athakor

Labels
api: firestore Issues related to the googleapis/java-firestore API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove error_prone_annotations exclusion rules from poms athakor/java-firestore
1 participant
@athakor