feat: enable auto-population of missing metadata in logs and printing structured logs to stdout #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OUT (#649) Add configuration to opt-out metadata auto-population. Add configuration to redirect appender output to stdout. Add relevant unit tests. Refactor unit tests. Improve javadoc comments for methods. Remove warnings. Make methods with no modifier to be private.
product-auto-label
bot
added
size: m
to allow unit testing to customize the logic auto-population should be skipped if monotored resource is set.
losalex
approved these changes
Jan 18, 2022
| @@ -57,4 +66,31 @@ custom_content: | | |||
| testLogger.log("test"); | |||
| } | |||
| } | |||
| ``` | |||
| @@ -90,7 +90,16 @@ See [Logback filters](https://logback.qos.ch/manual/filters.html#thresholdFilter | |||
| <!-- Optional: defaults to "ERROR" --> | |||
| <flushLevel>WARNING</flushLevel> | |||
|
|
|||
| <!-- Optional: auto detects on App Engine Flex, Standard, GCE and GKE, defaults to "global". See supported resource types --> | |||
| <!-- Optional: defaults to ASYNC --> | |||
There was a problem hiding this comment.
Are you supposing to edit README?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR aggregates the following changes:
Fixes Fixes #553 and #555.