Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update dependency com.google.cloud:google-cloud-logging to v3.10.6 #829

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Aug 19, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.google.cloud:google-cloud-logging 3.10.3 -> 3.10.6 age adoption passing confidence

Release Notes

googleapis/java-logging

v3.10.6

Dependencies

v3.10.5

Bug Fixes
  • resource detection for 2nd gen of Cloud Functions works incorrectly (#​1045) (dda1d0a)

v3.10.4

Dependencies
  • update dependency com.google.errorprone:error_prone_annotations to v2.15.0 (#​1037) (b2731c7)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Mend Renovate. View repository job log here.

@renovate-bot renovate-bot requested review from a team as code owners August 19, 2022 17:58
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 19, 2022
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Aug 19, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 19, 2022
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/java-logging-logback API. label Aug 19, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 19, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 19, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 19, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 19, 2022
@losalex losalex self-assigned this Aug 20, 2022
@losalex losalex added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 20, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 20, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 20, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 20, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 20, 2022
@lqiu96 lqiu96 added the automerge Merge the pull request once unit tests and other checks pass. label Aug 22, 2022
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 22, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 24, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 24, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 24, 2022
@renovate-bot renovate-bot changed the title deps: update dependency com.google.cloud:google-cloud-logging to v3.10.4 deps: update dependency com.google.cloud:google-cloud-logging to v3.10.5 Aug 25, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 25, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 25, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 25, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 28, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 28, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 28, 2022
@lqiu96
Copy link

lqiu96 commented Aug 29, 2022

Error:  Rule 2: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps failed with message:
Failed while enforcing RequireUpperBoundDeps. The error(s) are [
Require upper bound dependencies error for com.google.errorprone:error_prone_annotations:2.14.0 paths to dependency are:
+-com.google.cloud:google-cloud-logging-logback:0.127.6-alpha-SNAPSHOT
  +-com.google.cloud:google-cloud-logging:3.10.5
    +-com.google.errorprone:error_prone_annotations:2.14.0 (managed) <-- com.google.errorprone:error_prone_annotations:2.15.0
and
+-com.google.cloud:google-cloud-logging-logback:0.127.6-alpha-SNAPSHOT
  +-com.google.guava:guava:31.1-jre
    +-com.google.errorprone:error_prone_annotations:2.14.0 (managed) <-- com.google.errorprone:error_prone_annotations:2.11.0
and
+-com.google.cloud:google-cloud-logging-logback:0.127.6-alpha-SNAPSHOT
  +-com.google.cloud:google-cloud-logging:3.10.5
    +-com.google.api.grpc:proto-google-cloud-logging-v2:0.99.5
      +-com.google.errorprone:error_prone_annotations:2.14.0 (managed) <-- com.google.errorprone:error_prone_annotations:2.14.0
]

From: https://maven.apache.org/enforcer/enforcer-rules/requireUpperBoundDeps.html
Seems that google-cloud-logging is requiring v2.15.0 but the version being pulled in is v2.14.0

@lqiu96
Copy link

lqiu96 commented Aug 29, 2022

From the effective pom.xml

      <dependency>
        <groupId>com.google.errorprone</groupId>
        <artifactId>error_prone_annotations</artifactId>
        <version>2.14.0</version>
      </dependency>

google-cloud-logging has version v2.15.0

<dependency>
      <groupId>com.google.errorprone</groupId>
      <artifactId>error_prone_annotations</artifactId>
      <version>2.15.0</version>
      <scope>compile</scope>
      <optional>false</optional>
    </dependency>

Not sure why it's pulling in v2.14.0 (proto-google-cloud-logging) since is 2 leaps away google-cloud-logging -> proto-google-cloud-logging.
Error_prone from Guava seems to be 1 leap away (guava)

It should be pulling in v2.11.0 from guava? Either way it would fail the check since the upper bound is asking for v2.15.0. Could explicitly declare errorprone_annotations as a dependency (version can be set by shared-dependencies)

It is pulling it in due to the import scope of shared-dependencies. It has dependency management section which explicitly sets the version of errorprone to be v2.14.0. We've removed java-logging setting errorpone version explicitly to v2.15.0 and have it pull the version from shared-dependencies to keep the versions in sync.

gcf-merge-on-green bot pushed a commit to googleapis/java-logging that referenced this pull request Aug 29, 2022
Declaring the error_prone_annotation version fails consistency check in downstream repository:

googleapis/java-logging-logback#829 (comment)

Reading #1009, it shouldn't need the independent version declared here.
@renovate-bot renovate-bot changed the title deps: update dependency com.google.cloud:google-cloud-logging to v3.10.5 deps: update dependency com.google.cloud:google-cloud-logging to v3.10.6 Aug 29, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 29, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 29, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 29, 2022
@blakeli0 blakeli0 merged commit 66cd295 into googleapis:main Aug 30, 2022
@renovate-bot renovate-bot deleted the renovate/logging.version branch August 30, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/java-logging-logback API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants