Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for partialSuccess #908

Merged
merged 2 commits into from
Oct 31, 2022
Merged

feat: Add support for partialSuccess #908

merged 2 commits into from
Oct 31, 2022

Conversation

losalex
Copy link
Contributor

@losalex losalex commented Oct 31, 2022

Fixes #598 ☕️

@losalex losalex requested review from a team as code owners October 31, 2022 23:15
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: logging Issues related to the googleapis/java-logging-logback API. labels Oct 31, 2022
daniel-sanche
daniel-sanche approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@daniel-sanche daniel-sanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It might be useful if this flag could be set on a specific log entry too though, along with global configuration

@losalex losalex merged commit 1699f70 into main Oct 31, 2022
@losalex losalex deleted the losalex/feat-batching-partialSuccess branch October 31, 2022 23:36
@release-please release-please bot mentioned this pull request Oct 31, 2022
Merged
@losalex
Copy link
Contributor Author

losalex commented Oct 31, 2022

LGTM. It might be useful if this flag could be set on a specific log entry too though, along with global configuration

Thank you @daniel-sanche! Apparently, there is no such ability today, but perhaps we can think about it in the future

@release-please release-please bot mentioned this pull request Jan 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-sanche daniel-sanche daniel-sanche approved these changes

Assignees

@daniel-sanche daniel-sanche

Labels
api: logging Issues related to the googleapis/java-logging-logback API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@losalex @daniel-sanche