Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add consistent JUnit4 RunWith annotations on tests #1003

Closed
bpcreech opened this issue Jul 23, 2022 · 0 comments · Fixed by #1004
Closed

Add consistent JUnit4 RunWith annotations on tests #1003

bpcreech opened this issue Jul 23, 2022 · 0 comments · Fixed by #1004
Assignees
@losalex
Labels
api: logging Issues related to the googleapis/java-logging API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@bpcreech
Copy link
Contributor

Depending on test setup, it's either useful or mandatory to have consistent JUnit4 RunWith annotations on all tests. It's currently on some but not all tests.

Let's apply RunWith on all tests! (Will send a PR)
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/java-logging API. label Jul 23, 2022
@bpcreech bpcreech mentioned this issue Jul 23, 2022
Merged
@losalex losalex self-assigned this Jul 31, 2022
@losalex losalex added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@losalex losalex

Labels
api: logging Issues related to the googleapis/java-logging API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Add explicit RunWith annotations on all tests bpcreech/java-logging
2 participants
@bpcreech @losalex