Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LogEntryTest.java#testStructureLogPresentations is flaky #1005

Closed
bpcreech opened this issue Jul 23, 2022 · 0 comments · Fixed by #1006
Closed

LogEntryTest.java#testStructureLogPresentations is flaky #1005

bpcreech opened this issue Jul 23, 2022 · 0 comments · Fixed by #1006
Assignees
@losalex
Labels
api: logging Issues related to the googleapis/java-logging API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@bpcreech
Copy link
Contributor

LogEntryTest.java#testStructureLogPresentations is rendering a LogEntry into JSON and comparing it to a literal string.

This is flaky because JSON does not guarantee dictionary element ordering, and the order indeed does change (e.g., in my local tests).

Will send a PR to fix
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/java-logging API. label Jul 23, 2022
@bpcreech bpcreech mentioned this issue Jul 23, 2022
Merged
@losalex losalex self-assigned this Jul 31, 2022
@losalex losalex added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@losalex losalex

Labels
api: logging Issues related to the googleapis/java-logging API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fix flakiness in JSON test bpcreech/java-logging
2 participants
@bpcreech @losalex