fix: Replace internal Structs class with google-cloud-core version #1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
cindy-peng
force-pushed
the
cindy/update-core-structs
branch
from
59fa984
to
87126f5
Compare
product-auto-label
bot
added
size: l
gkevinzheng
approved these changes
Jan 8, 2024
| * This class contains static utility methods that operate on or return protobuf's {@code Struct} | ||
| * objects. | ||
| */ | ||
| final class Structs { |
There was a problem hiding this comment.
Just to be sure: this isn't public since it's missing the public modifier, right?
daniel-sanche
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1492 ☕️
The new common structs mapper utility in google cloud core including has been released yesterday in 3.21.0:
googleapis/sdk-platform-java#2290
googleapis/sdk-platform-java#2278
This is to replace the internal structs usage with the upstream version.