Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add logging bucket destination for log sinks #226

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

chingor13
Copy link
Collaborator

See: https://cloud.google.com/logging/docs/export

At some point, a new destination type was introduced which was causing the conversion from protobuf to fail on listSinks();

Fixes #217

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 1, 2020
@chingor13 chingor13 requested a review from a team September 1, 2020 21:12
@chingor13 chingor13 merged commit ef97aae into master Sep 1, 2020
@chingor13 chingor13 deleted the logging-bucket branch September 1, 2020 22:08
@nadav-lavy-exa
Copy link

nadav-lavy-exa commented Sep 3, 2020

Any timeline for a release with this fix?
Our application is broken for 16 days now due to this.
Edit: any plans to backport this to 1.x branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logging.it.ITLoggingTest: testListSinks failed
3 participants