Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging: Cannot specify resources when fetching log entries #23

Closed
chingor13 opened this issue Jul 16, 2019 · 0 comments · Fixed by #24
Closed

Logging: Cannot specify resources when fetching log entries #23

chingor13 opened this issue Jul 16, 2019 · 0 comments · Fixed by #24
Assignees
@pmakani
Labels
api: logging Issues related to the googleapis/java-logging API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@chingor13
Copy link
Collaborator

In LoggingImpl, the ListLogEntriesRequest is built and only specifies the projectId as the resource names: https://github.com/googleapis/google-cloud-java/blob/64189021c41c0f96b8a96beefb737cbf76be22c8/google-cloud-clients/google-cloud-logging/src/main/java/com/google/cloud/logging/LoggingImpl.java#L632-L653

The end-user should be able to somehow set the resource names fields.

RPC Specification

Note: this will require some substantial public interface changes.
@pmakani pmakani transferred this issue from googleapis/google-cloud-java Nov 26, 2019
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Nov 26, 2019
@pmakani pmakani mentioned this issue Nov 26, 2019
Merged
@pmakani pmakani added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Nov 26, 2019
@google-cloud-label-sync google-cloud-label-sync bot added the api: logging Issues related to the googleapis/java-logging API. label Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmakani pmakani

Labels
api: logging Issues related to the googleapis/java-logging API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: fix resourceNames pmakani/java-logging
3 participants
@chingor13 @pmakani @yoshi-automation