New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(sample): Add sample for Native Image support in Logging #880
Conversation
Warning: This pull request is touching the following templated files:
|
samples/native-image-sample/src/main/java/com/example/logging/NativeImageLoggingSample.java
Outdated
Show resolved
Hide resolved
…nto native-samples
samples/native-image-sample/src/test/java/com/example/logging/ITNativeImageLoggingSample.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving but the Java version should be 1.8.
Is Java version change considered as major upgrade? |
I am not sure this is safe move considering that Java downgrade might impact customers using this library. Perhaps we can talk about it to get full understanding of the fix? |
Oops sorry, didn't mean to edit your comment. For sure! we can discuss this further offline as well. Also adding reasoning for the change here to provide some context: It looks like all the samples in the repo use Java 8 for compilation since the Kokoro nightly jobs use that version to run the integration tests for the samples. This seems to be the only option at the moment until we upgrade the Java version on Kokoro. Open to hearing your thoughts on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…nto native-samples
…nto native-samples
This PR copies over the Logging sample, Setup Instructions and README for native image support from GoogleCloudPlatform/native-image-support-java. It also adds an integration test that can be run as a native image.
Calling
mvn package -Pnative -DskipTests
builds the native image executable for the application and callingmvn test -Pnative
runs the test as a native image.For more information: https://graalvm.github.io/native-build-tools/latest/maven-plugin.html#configuration