Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(sample): Add sample for Native Image support in Logging #880

Merged
merged 18 commits into from Mar 8, 2022

Conversation

mpeddada1
Copy link
Contributor

This PR copies over the Logging sample, Setup Instructions and README for native image support from GoogleCloudPlatform/native-image-support-java. It also adds an integration test that can be run as a native image.

Calling mvn package -Pnative -DskipTests builds the native image executable for the application and calling mvn test -Pnative runs the test as a native image.

For more information: https://graalvm.github.io/native-build-tools/latest/maven-plugin.html#configuration

@mpeddada1 mpeddada1 requested review from a team as code owners February 24, 2022 17:48
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • samples/pom.xml

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: logging Issues related to the googleapis/java-logging API. samples Issues that are directly related to samples. labels Feb 24, 2022
@mpeddada1 mpeddada1 changed the title Add sample for Native Image support in Logging docs(sample): Add sample for Native Image support in Logging Feb 24, 2022
@losalex losalex added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 1, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 1, 2022
Copy link
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but the Java version should be 1.8.

@losalex
Copy link
Contributor

losalex commented Mar 2, 2022

Approving but the Java version should be 1.8.

Is Java version change considered as major upgrade?

@mpeddada1
Copy link
Contributor Author

Is Java version change considered as major upgrade?

This java version change downgrades Java 11 to Java 8. We had to do this because using Java 11 causes the Kokoro Samples nightly job to fail with the following error:

@losalex
Copy link
Contributor

losalex commented Mar 3, 2022

I am not sure this is safe move considering that Java downgrade might impact customers using this library. Perhaps we can talk about it to get full understanding of the fix?

@mpeddada1
Copy link
Contributor Author

mpeddada1 commented Mar 3, 2022

I am not sure this is safe move considering that Java downgrade might impact customers using this library. Perhaps we can talk about it to get full understanding of the fix?

Oops sorry, didn't mean to edit your comment. For sure! we can discuss this further offline as well. Also adding reasoning for the change here to provide some context: It looks like all the samples in the repo use Java 8 for compilation since the Kokoro nightly jobs use that version to run the integration tests for the samples. This seems to be the only option at the moment until we upgrade the Java version on Kokoro. Open to hearing your thoughts on this.

Copy link
Contributor

@losalex losalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mpeddada1 mpeddada1 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 7, 2022
@losalex losalex added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Mar 8, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2022
@losalex losalex added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2022
@mpeddada1 mpeddada1 merged commit 7e59bf3 into main Mar 8, 2022
@mpeddada1 mpeddada1 deleted the native-samples branch March 8, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/java-logging API. samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants