Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Async logging should not rethrow error in onFailure callback #923

Merged
merged 1 commit into from Mar 31, 2022
Merged

fix: Async logging should not rethrow error in onFailure callback #923

merged 1 commit into from Mar 31, 2022

Conversation

losalex
Copy link
Contributor

@losalex losalex commented Mar 31, 2022

Async logging should not rethrow error in onFailure callback and print error in System.err

Fixes #645

@losalex losalex requested review from a team as code owners March 31, 2022 16:43
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: logging Issues related to the googleapis/java-logging API. labels Mar 31, 2022
minherz
minherz approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@minherz minherz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@losalex losalex merged commit 1adf867 into main Mar 31, 2022
@losalex losalex deleted the losalex/fix-645 branch March 31, 2022 17:03
@release-please release-please bot mentioned this pull request Mar 31, 2022
Merged
@jamestep
Copy link

This will not fix #645.
The issue is with the onFailure callback in writeLogEntries:

java-logging/google-cloud-logging/src/main/java/com/google/cloud/logging/LoggingImpl.java

Line 943 in 1adf867

throw new RuntimeException(ex);

@losalex
Copy link
Contributor Author

losalex commented Mar 31, 2022

This will not fix #645. The issue is with the onFailure callback in writeLogEntries:

java-logging/google-cloud-logging/src/main/java/com/google/cloud/logging/LoggingImpl.java

Line 943 in 1adf867

throw new RuntimeException(ex);

Thanks for your input @jamestep! Let me take a look again on this issue...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arbrown arbrown arbrown approved these changes

@minherz minherz minherz approved these changes

Assignees
No one assigned
Labels
api: logging Issues related to the googleapis/java-logging API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Async logging should not rethrow error in onFailure callback
4 participants
@losalex @jamestep @arbrown @minherz