This repository has been archived by the owner on Oct 2, 2023. It is now read-only.
fix: fix samples and samples tests for UptimeCheck. #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
blakeli0
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
averikitsch
reviewed
Aug 9, 2022
averikitsch
approved these changes
Aug 9, 2022
averikitsch
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Aug 11, 2022
🤖 I have created a release *beep* *boop* --- ## [3.4.1](v3.4.0...v3.4.1) (2022-08-11) ### Bug Fixes * fix samples and samples tests for UptimeCheck. ([#909](#909)) ([7143f96](7143f96)) * google-auth-library-oauth2-http is runtime scope ([#911](#911)) ([fb080db](fb080db)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
to meltsufin/monorepo-experiments
that referenced
this pull request
Aug 12, 2022
🤖 I have created a release *beep* *boop* --- ## [3.4.1](googleapis/java-monitoring@v3.4.0...v3.4.1) (2022-08-11) ### Bug Fixes * fix samples and samples tests for UptimeCheck. ([#909](googleapis/java-monitoring#909)) ([6ded514](googleapis/java-monitoring@6ded514)) * google-auth-library-oauth2-http is runtime scope ([#911](googleapis/java-monitoring#911)) ([fe4b919](googleapis/java-monitoring@fe4b919)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UpdateUptimeCheck, GetUptimeCheck and DeleteUptimeCheck have been failing because they are not taking the correct argument, instead of passing in display name, we should pass in the full check name. Hence every time the test was triggered, a new uptime check was created but was not cleaned up correctly, eventually we reached the limit of uptime check in the testing project and CreateUptimeCheck started failing too.
fixes #850
fixes #851
fixes #863
fixes #871