Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add parent in pom.xml #135

Merged
merged 3 commits into from
Sep 29, 2022
Merged

fix: add parent in pom.xml #135

merged 3 commits into from
Sep 29, 2022

Conversation

anguillanneuf
Copy link
Collaborator

@anguillanneuf anguillanneuf commented Sep 29, 2022 •
edited

Experienced some failure with /release/staging due to this error:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-deploy-plugin:2.7:deploy (default-deploy) on project
 pubsub-group-kafka-connector: Deployment failed: repository element was not specified in the POM inside 
distributionManagement element or in -DaltDeploymentRepository=id::layout::url parameter -> [Help 1]

In v0.1.0, we did not select packaging option, therefore, the release files (zip and tar.gz) available for download don't contain the connector jar.

Use mvn help::effective-pom to obtain the effective pom and compare it with that of java-pubsublite-spark.

@anguillanneuf anguillanneuf requested review from a team as code owners September 29, 2022 03:33
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Sep 29, 2022
@anguillanneuf anguillanneuf added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 29, 2022
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: s Pull request size is small. labels Sep 29, 2022
@anguillanneuf anguillanneuf removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 29, 2022
@anguillanneuf anguillanneuf changed the title fix: update distribution in pom.xml fix: add parent in pom.xml Sep 29, 2022
@anguillanneuf anguillanneuf merged commit f849afe into main Sep 29, 2022
@anguillanneuf anguillanneuf deleted the release-fix branch September 29, 2022 20:36
@release-please release-please bot mentioned this pull request Sep 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samarthsingal samarthsingal samarthsingal approved these changes

Assignees
No one assigned
Labels
size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anguillanneuf @samarthsingal