Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adding pubsub emulator example #1602

Merged

Conversation

maitrimangal
Copy link
Member

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@snippet-bot
Copy link

snippet-bot bot commented Jun 5, 2023

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Jun 5, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: pubsub Issues related to the googleapis/java-pubsub API. labels Jun 5, 2023
@hannahrogers-google hannahrogers-google changed the title Adding pubsub emulator example docs: adding pubsub emulator example Jun 5, 2023
Copy link
Contributor

@hannahrogers-google hannahrogers-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please get approval from Tianzi as well

Copy link
Contributor

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you. i'd recommend adding a test as well. feel free to create a new issue to track that work. you can use Cloud Build with a public container image with Pub/Sub emulator preinstalled to write the test.

cloudbuild.yaml example:

steps:
- name: gcr.io/google.com/cloudsdktool/cloud-sdk:433.0.1-emulators
   entrypoint: 'gcloud'
   args: ['beta', 'emulators', 'pubsub', 'start', '--project=abc', '--host-port=0.0.0.0:8085']
   env:
   - 'PUBSUB_EMULATOR_HOST=localhost:8085'

Also, don't forget to update docs or ping Moi Borah to update docs. :-)

@anguillanneuf anguillanneuf added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 5, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 5, 2023
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners June 5, 2023 20:57
@anguillanneuf anguillanneuf added owlbot:ignore instruct owl-bot to ignore a PR owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:ignore instruct owl-bot to ignore a PR labels Jun 5, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 12, 2023
@anguillanneuf anguillanneuf added owlbot:ignore instruct owl-bot to ignore a PR owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:ignore instruct owl-bot to ignore a PR labels Jun 12, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 12, 2023
@maitrimangal maitrimangal merged commit 8ded110 into googleapis:main Jun 12, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants