New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Message ordering fix for #1889 #1903
Merged
michaelpri10
merged 10 commits into
googleapis:main
from
michaelpri10:message-ordering-fix
Feb 9, 2024
Merged
fix: Message ordering fix for #1889 #1903
michaelpri10
merged 10 commits into
googleapis:main
from
michaelpri10:message-ordering-fix
Feb 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
Pull request size is small.
api: pubsub
Issues related to the googleapis/java-pubsub API.
labels
Feb 8, 2024
michaelpri10
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Feb 8, 2024
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Feb 8, 2024
…0/java-pubsub into message-ordering-fix
product-auto-label
bot
added
size: m
Pull request size is medium.
and removed
size: s
Pull request size is small.
labels
Feb 9, 2024
kamalaboulhosn
approved these changes
Feb 9, 2024
michaelpri10
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Feb 9, 2024
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Feb 9, 2024
michaelpri10
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Feb 9, 2024
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts PR #1807 to use a
LinkedHashMap
foroutstandingReceipts
and adds the synchronized keyword tonotifyAckSuccess
,notifyAckFailed
, andprocessReceivedMessages
in order to ensure message ordering is honored when exactly once delivery is enabled.Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1889 ☕️
If you write sample code, please follow the samples format.