Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Message ordering fix for #1889 #1903

Merged
merged 10 commits into from Feb 9, 2024

Conversation

michaelpri10
Copy link
Contributor

@michaelpri10 michaelpri10 commented Feb 8, 2024

This reverts PR #1807 to use a LinkedHashMap for outstandingReceipts and adds the synchronized keyword to notifyAckSuccess, notifyAckFailed, and processReceivedMessages in order to ensure message ordering is honored when exactly once delivery is enabled.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1889 ☕️

If you write sample code, please follow the samples format.

@michaelpri10 michaelpri10 requested a review from a team as a code owner February 8, 2024 23:38
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: pubsub Issues related to the googleapis/java-pubsub API. labels Feb 8, 2024
@michaelpri10 michaelpri10 added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 8, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 8, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Feb 9, 2024
@michaelpri10 michaelpri10 added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 9, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 9, 2024
@michaelpri10 michaelpri10 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 9, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 9, 2024
@michaelpri10 michaelpri10 merged commit 22a87c6 into googleapis:main Feb 9, 2024
22 checks passed
@michaelpri10 michaelpri10 deleted the message-ordering-fix branch February 9, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PubSub: Message ordering no longer being honored
3 participants