Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update pom to add comment #378

Merged
merged 2 commits into from
Jan 6, 2023
Merged

fix: update pom to add comment #378

merged 2 commits into from
Jan 6, 2023

Conversation

dpcollins-google
Copy link
Collaborator

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@dpcollins-google dpcollins-google requested review from a team as code owners January 6, 2023 20:00
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jan 6, 2023
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • samples/snapshot/pom.xml

@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite-kafka API. label Jan 6, 2023
@dpcollins-google dpcollins-google added the automerge Merge the pull request once unit tests and other checks pass. label Jan 6, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit f658ed3 into main Jan 6, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the dpcollins-google-patch-1 branch January 6, 2023 20:08
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 6, 2023
@release-please release-please bot mentioned this pull request Jan 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahrogers-google hannahrogers-google hannahrogers-google approved these changes

Assignees
No one assigned
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite-kafka API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dpcollins-google @hannahrogers-google