Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

docs(samples): Refactoring events package (new) #481

Merged
merged 18 commits into from Sep 13, 2022
Merged

docs(samples): Refactoring events package (new) #481

merged 18 commits into from Sep 13, 2022

Conversation

dfirova
Copy link
Contributor

@dfirova dfirova commented Jul 1, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@dfirova dfirova requested review from a team as code owners July 1, 2022 08:55
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: retail Issues related to the googleapis/java-retail API. samples Issues that are directly related to samples. labels Jul 1, 2022
@chenlei1216 chenlei1216 mentioned this pull request Jul 20, 2022
Merged
4 tasks
@dfirova dfirova mentioned this pull request Jul 26, 2022
Closed
4 tasks
kurtisvg
kurtisvg suggested changes Jul 27, 2022
View reviewed changes
samples/interactive-tutorials/src/main/java/events/ImportUserEventsBigQuery.java Outdated Show resolved Hide resolved
samples/interactive-tutorials/src/main/java/events/ImportUserEventsGcs.java Outdated Show resolved Hide resolved
samples/interactive-tutorials/src/main/java/events/ImportUserEventsGcs.java Show resolved Hide resolved
samples/interactive-tutorials/src/main/java/events/ImportUserEventsGcs.java Outdated Show resolved Hide resolved
samples/interactive-tutorials/src/main/java/events/setup/EventsCreateGcsBucket.java Outdated Show resolved Hide resolved
samples/interactive-tutorials/src/main/java/events/setup/RemoveEventsResources.java Show resolved Hide resolved
samples/interactive-tutorials/src/main/java/events/setup/UpdateUserEventsJson.java Show resolved Hide resolved
samples/interactive-tutorials/src/main/java/events/setup/UpdateUserEventsJson.java Outdated Show resolved Hide resolved
@dfirova dfirova requested a review from kurtisvg July 28, 2022 10:03
dfirova and others added 2 commits July 29, 2022 11:29
@dfirova @kurtisvg
PR fix: typo
2ae878d 
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
@dfirova
PR fixes: changed code according to the guidelines.
b9ed444
@dfirova dfirova requested a review from kurtisvg August 1, 2022 06:10
@dfirova
Copy link
Contributor Author

dfirova commented Aug 1, 2022

@kurtisvg returned commented parts with "check error handling", as they are part of the tutorials.

@alicejli alicejli added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 8, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 11, 2022
@averikitsch averikitsch added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 12, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 12, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 12, 2022
@averikitsch averikitsch added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 15, 2022
@dfirova
Copy link
Contributor Author

dfirova commented Aug 31, 2022

@averikitsch Kokoro tests haven't run in 15 days.

@blakeli0 blakeli0 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 31, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 31, 2022
@averikitsch averikitsch added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 1, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 1, 2022
@dfirova
Copy link
Contributor Author

dfirova commented Sep 7, 2022 •
edited

@chenlei1216 It's been almost a week and the owlBot check hasn't run yet.

@chenlei1216 chenlei1216 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 12, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 12, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 12, 2022
@kurtisvg kurtisvg merged commit 20d2539 into googleapis:main Sep 13, 2022
@release-please release-please bot mentioned this pull request Sep 13, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 16, 2022
@release-please
chore(main): release 2.5.0 (#532)
53ce196 
🤖 I have created a release *beep* *boop*
---


## [2.5.0](v2.4.0...v2.5.0) (2022-09-16)


### Features

* add local inventories info to the Product resource ([8204fbc](8204fbc))
* release AttributesConfig APIs to v2 version ([8204fbc](8204fbc))
* release CompletionConfig APIs to v2 version ([8204fbc](8204fbc))
* Release Control and ServingConfig serivces to v2 version ([#522](#522)) ([8204fbc](8204fbc))


### Bug Fixes

* **samples:** Removed add time from lro. ([#530](#530)) ([541e280](541e280))
* **samples:** Removed env variables and buckets from creating bq. ([#526](#526)) ([67152a6](67152a6))
* **samples:** Removed region tags ([#531](#531)) ([2d0dd5c](2d0dd5c))


### Documentation

* Improved documentation for Fullfillment and Inventory API in ProductService ([8204fbc](8204fbc))
* minor documentation format and typo fixes ([8204fbc](8204fbc))
* **samples:** Refactoring events package ([#481](#481)) ([20d2539](20d2539))
* **samples:** Refactoring product package ([#480](#480)) ([0c39897](0c39897))


### Dependencies

* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.5 ([#503](#503)) ([435df1b](435df1b))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.6 ([#519](#519)) ([9c37ee3](9c37ee3))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.7 ([#523](#523)) ([0da80f8](0da80f8))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.15.0 ([#524](#524)) ([ecb986a](ecb986a))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.16.0 ([#535](#535)) ([e7fa004](e7fa004))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#533](#533)) ([6236b06](6236b06))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#538](#538)) ([ab71781](ab71781))
* Update dependency com.google.cloud:google-cloud-storage to v2.11.3 ([#511](#511)) ([364b3d4](364b3d4))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit to meltsufin/monorepo-experiments that referenced this pull request Sep 17, 2022
@release-please
chore(main): release 2.5.0 (#532)
164b26b 
🤖 I have created a release *beep* *boop*
---


## [2.5.0](googleapis/java-retail@v2.4.0...v2.5.0) (2022-09-16)


### Features

* add local inventories info to the Product resource ([32a384d](googleapis/java-retail@32a384d))
* release AttributesConfig APIs to v2 version ([32a384d](googleapis/java-retail@32a384d))
* release CompletionConfig APIs to v2 version ([32a384d](googleapis/java-retail@32a384d))
* Release Control and ServingConfig serivces to v2 version ([#522](googleapis/java-retail#522)) ([32a384d](googleapis/java-retail@32a384d))


### Bug Fixes

* **samples:** Removed add time from lro. ([#530](googleapis/java-retail#530)) ([858b0e1](googleapis/java-retail@858b0e1))
* **samples:** Removed env variables and buckets from creating bq. ([#526](googleapis/java-retail#526)) ([eeb68fa](googleapis/java-retail@eeb68fa))
* **samples:** Removed region tags ([#531](googleapis/java-retail#531)) ([b12a8fe](googleapis/java-retail@b12a8fe))


### Documentation

* Improved documentation for Fullfillment and Inventory API in ProductService ([32a384d](googleapis/java-retail@32a384d))
* minor documentation format and typo fixes ([32a384d](googleapis/java-retail@32a384d))
* **samples:** Refactoring events package ([#481](googleapis/java-retail#481)) ([c644df0](googleapis/java-retail@c644df0))
* **samples:** Refactoring product package ([#480](googleapis/java-retail#480)) ([aebf241](googleapis/java-retail@aebf241))


### Dependencies

* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.5 ([#503](googleapis/java-retail#503)) ([58a7105](googleapis/java-retail@58a7105))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.6 ([#519](googleapis/java-retail#519)) ([dc52906](googleapis/java-retail@dc52906))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.7 ([#523](googleapis/java-retail#523)) ([3ad9ecf](googleapis/java-retail@3ad9ecf))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.15.0 ([#524](googleapis/java-retail#524)) ([2b6c293](googleapis/java-retail@2b6c293))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.16.0 ([#535](googleapis/java-retail#535)) ([826cbd6](googleapis/java-retail@826cbd6))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#533](googleapis/java-retail#533)) ([29807c8](googleapis/java-retail@29807c8))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#538](googleapis/java-retail#538)) ([e4170e8](googleapis/java-retail@e4170e8))
* Update dependency com.google.cloud:google-cloud-storage to v2.11.3 ([#511](googleapis/java-retail#511)) ([2c435e5](googleapis/java-retail@2c435e5))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chenlei1216 chenlei1216 chenlei1216 approved these changes

@kurtisvg kurtisvg kurtisvg approved these changes

Assignees

@kurtisvg kurtisvg

Labels
api: retail Issues related to the googleapis/java-retail API. samples Issues that are directly related to samples. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
8 participants
@dfirova @chenlei1216 @kurtisvg @blakeli0 @averikitsch @yoshi-kokoro @alicejli @sborisenkox