fix(java): Enable unit tests in generated libraries for native image testing #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpeddada1
changed the title
dzou
approved these changes
Jan 11, 2022
suztomo
reviewed
Jan 11, 2022
| @@ -829,6 +831,7 @@ | |||
| <buildArgs> | |||
| <buildArg>--no-fallback</buildArg> | |||
| <buildArg>--no-server</buildArg> | |||
| <buildArg>--features=com.google.cloud.nativeimage.features.ProtobufMessageFeature</buildArg> | |||
There was a problem hiding this comment.
Memo: To register reflection usage in unit tests for protobuf classes.
suztomo
approved these changes
Jan 11, 2022
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jan 11, 2022
🤖 I have created a release *beep* *boop* --- ### [1.2.5](v1.2.4...v1.2.5) (2022-01-11) ### Bug Fixes * **java:** Enable unit tests in generated libraries for native image testing ([#394](#394)) ([a453b9f](a453b9f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, only integration tests are enabled for native image testing in all libraries. However, the native-maven-plugin fails when no tests are run in a module. This affects modules don't have integration tests.
To increase test coverage, we decided to enable unit tests in generated libraries for native image testing.