Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: release ResultSet on Statement#close() #1567

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

olavloite
Copy link
Collaborator

Release the underlying resources of any ResultSet when Statement#close()
is called. This is necessary in case someone executes a query in
auto-commit mode using Statement#execute(String), and never reads and/or
closes the result that was returned.

Release the underlying resources of any ResultSet when Statement#close()
is called. This is necessary in case someone executes a query in
auto-commit mode using Statement#execute(String), and never reads and/or
closes the result that was returned.
@olavloite olavloite requested a review from a team as a code owner April 15, 2024 13:47
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner-jdbc API. labels Apr 15, 2024
@olavloite olavloite merged commit 2258ae3 into main Apr 16, 2024
26 checks passed
@olavloite olavloite deleted the release-resources-on-statement-close branch April 16, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner-jdbc API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants