Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jar with dependencies does not work in version 1.13 #79

Closed
olavloite opened this issue Mar 8, 2020 · 0 comments · Fixed by #80
Closed

Jar with dependencies does not work in version 1.13 #79

olavloite opened this issue Mar 8, 2020 · 0 comments · Fixed by #80
Assignees
@olavloite
Labels
api: spanner Issues related to the googleapis/java-spanner-jdbc API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@olavloite
Copy link
Collaborator

Building a jar with dependencies using the profile build-jdbc-driver does not result in a working jar as it misses the netty-shaded dependency. Using the jar will result in a No functional channel service provider found error to be thrown.
@olavloite olavloite added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: spanner Issues related to the googleapis/java-spanner-jdbc API. labels Mar 8, 2020
@olavloite olavloite self-assigned this Mar 8, 2020
@olavloite olavloite mentioned this issue Mar 8, 2020
Merged
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olavloite olavloite

Labels
api: spanner Issues related to the googleapis/java-spanner-jdbc API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add missing netty-shaded lib for über-jar googleapis/java-spanner-jdbc
2 participants
@olavloite @yoshi-automation