Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(java): adding resource and reflection configurations for native image testing #809

Merged
merged 96 commits into from
May 31, 2022
Merged

fix(java): adding resource and reflection configurations for native image testing #809

merged 96 commits into from
May 31, 2022

Conversation

mpeddada1
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@mpeddada1 mpeddada1 requested review from a team as code owners April 21, 2022 22:39
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: spanner Issues related to the googleapis/java-spanner-jdbc API. labels Apr 21, 2022
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xl Pull request size is extra large. labels Apr 22, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 25, 2022
@mpeddada1
Copy link
Contributor Author

Remove the sdk dependency once the spanner is upgraded in #881

@mpeddada1
Copy link
Contributor Author

Spanner 6.25.4 was released so testing after the upgrade.

@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels May 27, 2022
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels May 27, 2022
@mpeddada1 mpeddada1 mentioned this pull request May 27, 2022
Merged
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels May 31, 2022
@mpeddada1 mpeddada1 removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels May 31, 2022
@mpeddada1 mpeddada1 merged commit 6126d4f into main May 31, 2022
@mpeddada1 mpeddada1 deleted the troubleshoot-native-2 branch May 31, 2022 21:18
@release-please release-please bot mentioned this pull request May 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansh0l ansh0l ansh0l approved these changes

@suztomo suztomo Awaiting requested review from suztomo

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/java-spanner-jdbc API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mpeddada1 @ansh0l @yoshi-kokoro @rajatbhatta @olavloite