Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update dependency com.google.cloud:google-cloud-spanner-bom to v6.25.2 #881

Merged
merged 4 commits into from May 27, 2022
Merged

deps: update dependency com.google.cloud:google-cloud-spanner-bom to v6.25.2 #881

merged 4 commits into from May 27, 2022

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented May 26, 2022 •
edited

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.google.cloud:google-cloud-spanner-bom 6.23.3 -> 6.25.4 age adoption passing confidence

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, click this checkbox. ⚠ Warning: custom changes will be lost.

This PR has been generated by Mend Renovate. View repository job log here.

@renovate-bot renovate-bot requested review from a team as code owners May 26, 2022 00:14
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 26, 2022
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label May 26, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label May 26, 2022
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner-jdbc API. label May 26, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 26, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 26, 2022
@blakeli0 blakeli0 added the automerge Merge the pull request once unit tests and other checks pass. label May 26, 2022
@rajatbhatta rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 26, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 26, 2022
rajatbhatta
rajatbhatta approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@rajatbhatta rajatbhatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rajatbhatta
test: fix assert for testConnectWithCredentialsAndOAuthToken
4c562c5 
testConnectWithCredentialsAndOAuthToken test was failing with following error -
JdbcDriverTest.testConnectWithCredentialsAndOAuthToken:135 expected to contain: Cannot specify both credentials and an OAuth token
but was : INVALID_ARGUMENT: Specify only one of credentialsUrl, encodedCredentials, credentialsProvider and OAuth token.

Changing assertThat to account for this change. The exception message was changed as part of googleapis/java-spanner#1869.
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 26, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 26, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 26, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 26, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 26, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 26, 2022
@rajatbhatta rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 26, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 26, 2022
@mpeddada1 mpeddada1 mentioned this pull request May 26, 2022
Merged
4 tasks
@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 26, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 26, 2022
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 27, 2022
@Neenu1995 Neenu1995 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 27, 2022
@mpeddada1
Copy link
Contributor

The stacktrace shows:

java.lang.AssertionError:
expected exception: EXPLAIN SELECT *
        FROM Singers
	at org.junit.Assert.fail(Assert.java:89)
	at com.google.cloud.spanner.connection.AbstractSqlScriptVerifier.verifyStatement(AbstractSqlScriptVerifier.java:365)
	at com.google.cloud.spanner.connection.AbstractSqlScriptVerifier.lambda$verifyStatementsInFile$0(AbstractSqlScriptVerifier.java:315)
	at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1384)
	at java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:647)
	at com.google.cloud.spanner.connection.AbstractSqlScriptVerifier.verifyStatementsInFile(AbstractSqlScriptVerifier.java:297)
	at com.google.cloud.spanner.jdbc.it.ITJdbcScriptTest.test13_TestInvalidStatements(ITJdbcScriptTest.java:367)

@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 27, 2022
@blakeli0
Copy link

blakeli0 commented May 27, 2022 •
edited

@rajatbhatta @ansh0l Can you please take a look at the test failure? We are in the middle of a release and this is a blocker for us.

@olavloite
Copy link
Collaborator

@blakeli0 I'll take a look. This is caused by a new feature that was recently added to the client library.

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 27, 2022
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels May 27, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 27, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 27, 2022
@olavloite
Copy link
Collaborator

googleapis/java-spanner#1852 added support for the EXPLAIN keyword for PostgreSQL dialect databases recently.

@mpeddada1
Copy link
Contributor

Thanks @olavloite!

@blakeli0 blakeli0 added the automerge Merge the pull request once unit tests and other checks pass. label May 27, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit b1980b6 into googleapis:main May 27, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 27, 2022
@release-please release-please bot mentioned this pull request May 27, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request May 27, 2022
@release-please
chore(main): release 2.7.1 (#883)
ddd48b8 
🤖 I have created a release *beep* *boop*
---


### [2.7.1](v2.7.0...v2.7.1) (2022-05-27)


### Dependencies

* update dependency com.google.cloud:google-cloud-spanner-bom to v6.25.2 ([#881](#881)) ([b1980b6](b1980b6))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@rajatbhatta rajatbhatta mentioned this pull request May 31, 2022
Closed
@renovate-bot renovate-bot deleted the renovate/com.google.cloud-google-cloud-spanner-bom-6.x branch May 31, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakeli0 blakeli0 blakeli0 approved these changes

@rajatbhatta rajatbhatta rajatbhatta approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/java-spanner-jdbc API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@renovate-bot @mpeddada1 @blakeli0 @olavloite @rajatbhatta @Neenu1995 @yoshi-kokoro