Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Copy Backup Support #1778

Merged
merged 21 commits into from
Mar 28, 2022
Merged

feat: Copy Backup Support #1778

merged 21 commits into from
Mar 28, 2022

Conversation

asthamohta
Copy link
Contributor

No description provided.

@asthamohta asthamohta requested review from a team as code owners March 24, 2022 08:52
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • samples/pom.xml

@product-auto-label product-auto-label bot added api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. labels Mar 24, 2022
@snippet-bot
Copy link

snippet-bot bot commented Mar 24, 2022 •
edited
Loading

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

thiagotnunes
thiagotnunes reviewed Mar 25, 2022
View reviewed changes
Copy link
Contributor

@thiagotnunes thiagotnunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be careful when accepting my code suggestions, as you need to change the commit title, otherwise the conventionalcommits check will fail. Feel free to, instead of accepting the suggestions, implementing the same in your local machine.

google-cloud-spanner/src/main/java/com/google/cloud/spanner/BackupInfo.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/BackupInfo.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/BackupInfo.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/BackupInfo.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/BackupInfo.java Outdated
*
* <p>Returns the names of the destination backups being created by copying this source backup.
*/
protected abstract Builder setReferencingBackup(ProtocolStringList referencingBackup);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not use the protobuf specific types here. Instead of ProtocolStringList, could you use List<String>?

google-cloud-spanner/src/test/java/com/google/cloud/spanner/BackupTest.java Show resolved Hide resolved
samples/pom.xml Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseAdminClient.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseAdminClient.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/SpannerRpc.java Outdated Show resolved Hide resolved
thiagotnunes
thiagotnunes requested changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@thiagotnunes thiagotnunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to resolve the breaking changes, populate the new fields when reading the proto and remove the samples

@asthamohta asthamohta changed the title feat: Copy Backup support and samples feat: Copy Backup support Mar 25, 2022
@asthamohta asthamohta added owlbot:run Add this label to trigger the Owlbot post processor. and removed api: spanner Issues related to the googleapis/java-spanner API. labels Mar 25, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 25, 2022
@asthamohta asthamohta added owlbot:run Add this label to trigger the Owlbot post processor. api: spanner Issues related to the googleapis/java-spanner API. and removed samples Issues that are directly related to samples. labels Mar 25, 2022
@asthamohta asthamohta changed the title feat: Copy Backup support feat: Copy Backup Support Mar 25, 2022
thiagotnunes
thiagotnunes reviewed Mar 25, 2022
View reviewed changes
google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/SpannerRpc.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/BackupTest.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/Backup.java
@@ -183,6 +183,8 @@ static Backup fromProto(
.setDatabase(DatabaseId.of(proto.getDatabase()))
.setEncryptionInfo(EncryptionInfo.fromProtoOrNull(proto.getEncryptionInfo()))
.setProto(proto)
.setMaxExpireTime(Timestamp.fromProto(proto.getMaxExpireTime()))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we test with null max expire time and null referencingBackupsList?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We won't get a null value over here. The addAll function checks for non null values-> https://github.com/protocolbuffers/protobuf/blob/master/java/core/src/main/java/com/google/protobuf/AbstractMessageLite.java#L408

thiagotnunes
thiagotnunes reviewed Mar 25, 2022
View reviewed changes
Copy link
Contributor

@thiagotnunes thiagotnunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove my request changes so you are not blocked by my review, but please address the method name change

@asthamohta asthamohta added owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 28, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 28, 2022
@asthamohta asthamohta merged commit dc79366 into googleapis:main Mar 28, 2022
@release-please release-please bot mentioned this pull request Mar 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

@thiagotnunes thiagotnunes thiagotnunes approved these changes

@rajatbhatta rajatbhatta rajatbhatta approved these changes

@ansh0l ansh0l Awaiting requested review from ansh0l

Assignees

@lesv lesv

Labels
api: spanner Issues related to the googleapis/java-spanner API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@asthamohta @thiagotnunes @olavloite @rajatbhatta @lesv @ansh0l