Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PostgreSQL parser should not treat \ as an escape char #1921

Merged
merged 4 commits into from
Jun 22, 2022

Conversation

olavloite
Copy link
Collaborator

The PostgreSQL parser that removes comments and checks the type of
statement should not consider a backslash inside a quoted literal or
identifier as an escape character. Instead, only double occurrences of
the same quotes as the begin/end quote should be considered as an escape
inside a quoted literal or identifier.

Fixes #1920

The PostgreSQL parser that removes comments and checks the type of
statement should not consider a backslash inside a quoted literal or
identifier as an escape character. Instead, only double occurrences of
the same quotes as the begin/end quote should be considered as an escape
inside a quoted literal or identifier.

Fixes #1920
@olavloite olavloite requested a review from a team as a code owner June 22, 2022 06:46
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner API. labels Jun 22, 2022
@olavloite olavloite added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 22, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 22, 2022
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 22, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 22, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 260bbe3 into main Jun 22, 2022
@gcf-merge-on-green gcf-merge-on-green bot deleted the issue-1920 branch June 22, 2022 10:38
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 22, 2022
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 22, 2022
🤖 I have created a release *beep* *boop*
---


## [6.25.6](v6.25.5...v6.25.6) (2022-06-22)


### Bug Fixes

* PostgreSQL parser should not treat \ as an escape char ([#1921](#1921)) ([260bbe3](260bbe3)), closes [#1920](#1920)


### Documentation

* **sample:** relocate native image sample from old repo ([#1758](#1758)) ([ef187f4](ef187f4))


### Dependencies

* update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.11 ([#1907](#1907)) ([01f8a07](01f8a07))
* update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.12 ([#1918](#1918)) ([be8b50b](be8b50b))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
gcf-owl-bot bot added a commit that referenced this pull request Jan 30, 2024
…nfig artifact (#1921)

chore: update renovate bot configs to update the sdk-platform-java-config artifact
Source-Link: googleapis/synthtool@d7828c0
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:0d1bb26a1a99ae0456176bf891b8490e9aab424a5cb4e4d301d9703c4dc43b58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PostgreSQL Connection API wrongly identifies slash as an escape character in quoted literals and identifiers
4 participants