Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add custom instance config operations #1999

Merged
merged 6 commits into from
Sep 16, 2022
Merged

feat: Add custom instance config operations #1999

merged 6 commits into from
Sep 16, 2022

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Sep 7, 2022

  • Regenerate this pull request now.

PiperOrigin-RevId: 474535825

Source-Link: googleapis/googleapis@69c840e

Source-Link: https://github.com/googleapis/googleapis-gen/commit/33e360e7d4bf2479fa79eace85166453cd760b0d
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzNlMzYwZTdkNGJmMjQ3OWZhNzllYWNlODUxNjY0NTNjZDc2MGIwZCJ9

fix!: Revert add custom instance config operations (change broke client libraries; reverting before any are released)
PiperOrigin-RevId: 473985182

Source-Link: googleapis/googleapis@e544df5

Source-Link: https://github.com/googleapis/googleapis-gen/commit/a17c20e34f08de8fb5f9a3e5bb429f42b8d75cdd
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYTE3YzIwZTM0ZjA4ZGU4ZmI1ZjlhM2U1YmI0MjlmNDJiOGQ3NWNkZCJ9

feat: Add custom instance config operations
PiperOrigin-RevId: 473928081

Source-Link: googleapis/googleapis@5440048

Source-Link: https://github.com/googleapis/googleapis-gen/commit/840feecd758adacc102d6b86e66544a0c1c37054
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODQwZmVlY2Q3NThhZGFjYzEwMmQ2Yjg2ZTY2NTQ0YTBjMWMzNzA1NCJ9

chore(bazel): Update WORKSPACE files for rules_gapic, gax_java, generator_java versions

PiperOrigin-RevId: 472750037

Source-Link: googleapis/googleapis@88f2ea3

Source-Link: https://github.com/googleapis/googleapis-gen/commit/230a5588306aae18fe8f2a57f14d4039ad72c901
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjMwYTU1ODgzMDZhYWUxOGZlOGYyYTU3ZjE0ZDQwMzlhZDcyYzkwMSJ9

@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners September 7, 2022 19:02
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Sep 7, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 7, 2022
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Sep 7, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 7, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 7, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 7, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 7, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 7, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 7, 2022
ansh0l
ansh0l previously requested changes Sep 7, 2022
Copy link
Contributor

@ansh0l ansh0l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes to put this on hold, since it depends on release of gax_java.

@gcf-owl-bot
Copy link
Contributor Author

gcf-owl-bot bot commented Sep 9, 2022

Owl bot is regenerating pull request 1999...
Build name: MmUzNDViY2EtZTU5Ni00NmYxLTg1ZDYtNTQ2OTkyMDZhNTFm

@meltsufin meltsufin added the automerge Merge the pull request once unit tests and other checks pass. label Sep 9, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 9, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 9, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 9, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 9, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 9, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 9, 2022
@meltsufin meltsufin added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 9, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 9, 2022
@meltsufin meltsufin dismissed ansh0l’s stale review September 9, 2022 19:14

gax has now been release and the ci is green

@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 13, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 13, 2022
@jskeet jskeet added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 13, 2022
@jskeet
Copy link

jskeet commented Sep 13, 2022

Even if the breakage in this PR could be fixed, it looks like this change will be rolled back - so please don't merge this PR without checking further.

…nt libraries; reverting before any are released)

PiperOrigin-RevId: 473985182

Source-Link: googleapis/googleapis@e544df5

Source-Link: googleapis/googleapis-gen@a17c20e
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYTE3YzIwZTM0ZjA4ZGU4ZmI1ZjlhM2U1YmI0MjlmNDJiOGQ3NWNkZCJ9
@gcf-owl-bot gcf-owl-bot bot changed the title feat: Add custom instance config operations fix!: Revert add custom instance config operations (change broke client libraries; reverting before any are released) Sep 13, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 13, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 13, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 13, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 13, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 13, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 13, 2022
PiperOrigin-RevId: 474535825

Source-Link: googleapis/googleapis@69c840e

Source-Link: googleapis/googleapis-gen@33e360e
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzNlMzYwZTdkNGJmMjQ3OWZhNzllYWNlODUxNjY0NTNjZDc2MGIwZCJ9
@gcf-owl-bot gcf-owl-bot bot changed the title fix!: Revert add custom instance config operations (change broke client libraries; reverting before any are released) feat: Add custom instance config operations Sep 15, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 15, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 15, 2022
@rahul2393 rahul2393 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 15, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 15, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 15, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 15, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 15, 2022
@ansh0l ansh0l merged commit 74f9c3b into main Sep 16, 2022
@ansh0l ansh0l deleted the owl-bot-copy branch September 16, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. owl-bot-copy size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants