feat: capture stack trace for session checkout is now optional #2350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The session pool by default captures the stack trace of the thread that checks out a session of the pool, so this can be used in case the session is leaked. This is done by creating an exception already at the moment that the session is checked out. Some monitoring tools log the creation of this exception, giving the impression that the application is throwing a large number of errors, while the error is actually never thrown. This commit makes this capturing optional. The default is to capture the call stack, but users can turn this off in the SessionPoolOptions.
product-auto-label
bot
added
size: m
rajatbhatta
approved these changes
Apr 6, 2023
google-cloud-spanner/src/main/java/com/google/cloud/spanner/SessionPoolOptions.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/SessionPoolOptions.java
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/SessionPoolOptions.java
Outdated
Show resolved
Hide resolved
rajatbhatta
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
rajatbhatta
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Apr 11, 2023
🤖 I have created a release *beep* *boop* --- ## [6.39.0](https://togithub.com/googleapis/java-spanner/compare/v6.38.2...v6.39.0) (2023-04-11) ### Features * Capture stack trace for session checkout is now optional ([#2350](https://togithub.com/googleapis/java-spanner/issues/2350)) ([6b6427a](https://togithub.com/googleapis/java-spanner/commit/6b6427a25af25fde944dfc1dd4bf6a6463682caf)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The session pool by default captures the stack trace of the thread that checks out a session of the pool, so this can be used in case the session is leaked. This is done by creating an exception already at the moment that the session is checked out. Some monitoring tools log the creation of this exception, giving the impression that the application is throwing a large number of errors, while the error is actually never thrown.
This commit makes this capturing optional. The default is to capture the call stack, but users can turn this off in the SessionPoolOptions.
Fixes #2266